[ ] I have validated my changes against all supported platform versions
I did not validate it against all platform versions, but rather than use something like present? or try or &. I just used the ruby idiom for checking nil/false by using the object at the end, like && object
Have you considered putting that last requirement into the CI's hands so that it might become unnecessary?
Related issues
None that I am aware of.
Describe the solution you've provided
The code previously checked that Rails responded to logger and if it did, assumes there is actually a logger present, which is not always the case. This leaves LD with a nil value for logger which causes the application to crash.
Requirements
I did not validate it against all platform versions, but rather than use something like
present?
ortry
or&.
I just used the ruby idiom for checking nil/false by using the object at the end, like&& object
Have you considered putting that last requirement into the CI's hands so that it might become unnecessary?
Related issues
None that I am aware of.
Describe the solution you've provided
The code previously checked that Rails responded to
logger
and if it did, assumes there is actually a logger present, which is not always the case. This leaves LD with anil
value forlogger
which causes the application to crash.Describe alternatives you've considered
I did not consider any alternatives.
Additional context
None.