launchdarkly / ruby-server-sdk

LaunchDarkly Server-side SDK for Ruby
https://docs.launchdarkly.com/sdk/server-side/ruby
Other
36 stars 53 forks source link

fix: Allow gem to be installed from source #305

Closed javierjulio closed 3 weeks ago

javierjulio commented 3 weeks ago

Requirements

Related issues

In #303 I was asked to install the gem in my Gemfile from source to confirm a bug fix but I encountered two bundle install errors that prevented that. I had to make these changes to be able to successfully install from source.

Describe the solution you've provided

Do not depend on rake in the gemspec as there is no need too. Replacing Rake's FileList with Ruby's Dir is a common use for the affected line and can be seen in many popular gemspecs.

Describe alternatives you've considered

I didn't consider any alternatives because it would be best to not depend on an unnecessary dependency (e.g. rake) in the gemspec file. This also follows what is commonly done in other Ruby gems so it's well supported.

keelerm84 commented 3 weeks ago

Thank you for your contribution!