launchdarkly / rust-server-sdk

LaunchDarkly Server-Side SDK for Rust
https://docs.launchdarkly.com/sdk/server-side/rust
Other
18 stars 13 forks source link

fix: Bump MSRV to 1.70.0 #61

Closed keelerm84 closed 6 months ago

shortcut-integration[bot] commented 6 months ago

This pull request has been linked to Shortcut Story #226796: Bump Rust SDK dependencies to fix security vulnerability.

keelerm84 commented 6 months ago

You can see my other two PRs are failing because of a change to the MSRV for a downstream dependency (https://github.com/launchdarkly/rust-server-sdk/pull/59 and https://github.com/launchdarkly/rust-server-sdk/pull/60).

The dependency that is causing a problem is only required for testing. This means we could theoretically keep the MSRV at 1.68. We just could never run unit tests on that compiler version. But we could continue running the contract tests.

Thoughts?