Allows to configure the used URLSessionConfiguration

arupsch commented 3 years ago

Requirements

[ ] I have added test coverage for new or changed functionality
[ x] I have followed the repository's pull request submission guidelines
[x ] I have validated my changes against all supported platform versions

Related issues

No linked issue for that.

Describe the solution you've provided

This adds the capability to provide a URLSessionConfiguration that is used when the URLSession is created. This helps with testing, because this way it is possible to configure an URLProtocol implementation to provide test responses.

Describe alternatives you've considered

No alternatives considered

Additional context

No additional context

torchhound commented 3 years ago

Hi @arupsch thanks for submitting this patch. We will internally review it!

gwhelanLD commented 3 years ago

Hi @arupsch,

Could you take a look at https://github.com/launchdarkly/swift-eventsource/pull/27 and see if it meets your needs? The description there describes the intention behind the differing implementation.

Thanks for the PR with this idea! @gwhelanLD

gwhelanLD commented 3 years ago

Closing as we're moving forward with https://github.com/launchdarkly/swift-eventsource/pull/27, but thanks for the contribution!

Thanks, @gwhelanLD

launchdarkly / swift-eventsource

Allows to configure the used URLSessionConfiguration #22