search

launchdarkly / swift-eventsource

Server-sent events (SSE) client implementation in Swift for iOS, macOS, tvOS, and watchOS
https://launchdarkly.github.io/swift-eventsource/
Other
187 stars 34 forks source link

Add Privacy manifests #74

Closed yasiraliraj closed 5 months ago

yasiraliraj commented 5 months ago

@keelerm84 Do you think this library also needs to add privacy manifest file?

louis-launchdarkly commented 5 months ago

Hello @yasiraliraj, thank you for raising this question. While I am quite certain the event source library doesn't access device info (as this is a network library), it seems this is still an open question between no manifest or an empty manifest. If you have information about which one is better, please let us know.

yasiraliraj commented 5 months ago

I think better is not to add manifest, if we are not using any device info.

keelerm84 commented 5 months ago

I think better is not to add manifest, if we are not using any device info.

That sounds reasonable to me. We aren't relying on anything that would require a privacy manifest, so I'll go ahead and close this issue.

abiligiri commented 5 months ago

This may need a privacy manifest. This will appear as a separate framework when dynamically linked and Apple checks may reject apps with this. Can you please reconsider?