launchdarkly / terraform-provider-launchdarkly

Terraform LaunchDarkly provider

https://www.terraform.io/docs/providers/launchdarkly/

Mozilla Public License 2.0

22 stars 24 forks source link

add critical property to `launchdarkly_environment` resource #206

Closed cdschneider closed 4 months ago

cdschneider commented 5 months ago

Overview

Environments can be marked as critical, so the launchdarkly_environment resource should support this by adding a boolean property named critical.

lucywyman commented 5 months ago

Hi! It looks to me like the work for this has been done, I'll look into why it hasn't been released (or maybe it just didn't get documented?) later today!

cdschneider commented 5 months ago

Hi @lucywyman, any update on this?

lucywyman commented 5 months ago

Yes! The person who implemented it wants to add some more tests before releasing, we have a ticket for that that I believe is getting worked on this week. I'm sorry for the delay, we're busy right now preparing for our Galaxy conference - I appreciate your patience!

sunnyguduru commented 4 months ago

Hello, we've released v2.18.3 with the critical property on launchdarkly_environment.

andrewstucki commented 4 months ago

Just FYI, this introduced a breaking change against people's prod environments. According to the docs, production environments by default get marked as "critical". Since critical now defaults to false anyone who has created an environment marked as a production environment with the provider, by upgrading a patch version, winds up seeing a diff that looks like this: