launchflow / buildflow

BuildFlow, is an open source framework for building large scale systems using Python. All you need to do is describe where your input is coming from and where your output should be written, and BuildFlow handles the rest. No configuration outside of the code is required.
https://docs.launchflow.com/buildflow
Apache License 2.0
193 stars 7 forks source link

BuildFlow parent resource should fail if a child resource fails to create #331

Open boetro opened 11 months ago

boetro commented 11 months ago

Describe the bug Sometimes a child resource will fail to create (such as a CloudSQL Instance) but the buildflow parent resource we wrap it in will still be "created", this make the output generated by the next call to apply to be incorrect.

To Reproduce

  1. Setup a flow with a cloud sql instance primitive
  2. Add some invalid parameter like a gcp project that doesn't exist
  3. Run buildflow apply (this step will fail due to the above step)
  4. Run buildflow apply again (this step will have the Cloud SQL Primitive excluded from the output)

Expected behavior I would expect step number four above to still output the Cloud SQL Instance primitive as needs to be created

Screenshots N/A

Desktop (please complete the following information): N/A

Additional context N/A