launchiamenterprise / keyrunner

KeyRunner: A secure, codeless VS Code extension for API testing & Designing. Features include data encryption at rest, sensitive data masking, and the innovative Playground for chaining API requests without coding
https://keyrunner.app
MIT License
15 stars 1 forks source link

Feat(ux): Add additional request tab visual status indicators when tab actually contains data inside #81

Open frank-duq opened 1 month ago

frank-duq commented 1 month ago

Describe the solution you'd like Just like how postman does it, it would be nice if keyrunner could show some visual status indicator next to a request tab name, if the tab contains some user-provided data (e..g non-empty), to make it easier to navigate tabs that actually contain something, without having to click on all tabs to discover if it contains some user-provided data or not, this includes the internal pre and post script sections.. (useful, when plenty of collection requests to maintain etc).

Describe alternatives you've considered Currently, one has to click on all tabs one by one to find if there's user defined data inside, which takes additional time and clicks to navigate etc.

Additional context

Here's how Postman is doing it: Screenshot 2024-10-16 at 12 40 47 PM

Here's Keyrunner, as of 1.0.67, showing where new visual indicators could be added: Screenshot 2024-10-16 at 12 41 30 PM

thanks

launchiamenterprise commented 1 month ago

@frank-duq we currently have this feature implemented for params, authorization ,headers & body tabs . We will add that for scripts & tests.

image
frank-duq commented 1 month ago

hmm, that's not the current behaviour that I'm observing (1.0.67), what I'm actually seeing, is that the green dot indicator shows up when I do some updates (e.g. unsaved changes), but it disappear as soon as I hit the save button.

so those are actually 2 separate things, e.g.:

1- having an indicator to tell the user that you have unsaved changes is super important and definitely needed; however, that's not what I was referring here in current issue, but the next point..

2- having 'permanent indicators' telling the user which tabs/sections contain actual data, that's the one current ticket is talking about, and which doesn't seem to be supported for all tabs EXCEPT: "Params" and "Headers", for which, both are showing a number to the right of the tab name, which could also be added for the tab "Tests" since it can be measured, but can't be done for "Authorization" and "Scripts" tabs, so for those ones, just some kind of 'dot' icon/indicator would be enough to tell the user that the tab does contain user-provided data (I'm not talking about unsaved changes here, but just whether or not the tab contains data......just like what Postman does with their 'dot' indicators next to tabs' names..).

thanks

launchiamenterprise commented 1 month ago

Got it! Thank you for clarifying. We will work on enhancing this feature to have permanent indicators when there is actual data.

launchiamenterprise commented 1 month ago

@frank-duq This has been addressed with our latest release (V#1.0.69), Please update to latest version.

frank-duq commented 1 month ago

Thanks for looking into this!

Some more feedback, after testing the updates with latest 1.0.69:

Screenshot 2024-10-21 at 12 35 11 PM

launchiamenterprise commented 1 month ago

@frank-duq Based on your feedback, we have addressed the above in the latest release, v1.0.70. Please update to the latest version.

frank-duq commented 1 month ago

Awesome updates, much better overall UX, I like it great work.

One tiny feedback though, when I update the body of a request, it does add the star (*) icon next to the "Body" tab label, which is perfect!

However, it ALSO adds a star (*) to the "Headers" tab label as well, just like if I had modified both at the same time, which is not the case, I've only modified the "Body", so there should not be a star added to the "Headers" too.

But so far, all the rest seems to be working very nicely, e.g. all blue dot indicators showing what panel contains actual data, and then the green stars that appear when we modify some content and needs to save, very great experience.

launchiamenterprise commented 1 month ago

thank you for the feedback , we will fix that "Body" label bug in our next release. Our main focus for this release was the Request Body Variables Update(https://github.com/launchiamenterprise/keyrunner/issues/84).

we will keep this issue open.