launchiamenterprise / keyrunner

KeyRunner: A secure, codeless VS Code extension for API testing & Designing. Features include data encryption at rest, sensitive data masking, and the innovative Playground for chaining API requests without coding
https://keyrunner.app
MIT License
15 stars 1 forks source link

Feat: Add json request body formatter/beautifier #82

Open frank-duq opened 1 month ago

frank-duq commented 1 month ago

Describe the solution you'd like Just like with Postman, it would be nice to add a json formatter, when copy/pasting from some external sources unformatted json. (or even copying from within the keyrunner console itself some one-liner unformatted request json 'data'..)

Describe alternatives you've considered Currently using some online external tools such as https://jsonformatter.org/ to do the formatting, which requires a separate tool to do it, rather than doing it from within keyrunner.

Additional context

The formatter/beautifier feature, in Postman: Screenshot 2024-10-16 at 1 11 08 PM

Currently, in Keyrunner 1.0.67: Screenshot 2024-10-16 at 1 11 37 PM

frank-duq commented 1 month ago

Also, while we're there talking about that specific area of the UI, minor but it feels like the current position of that body data type picker (JSON | XML | Text) is off and floating around, rather than being positioned perhaps in the section right above where other selectors/tabs are made available:

Screenshot 2024-10-18 at 12 19 24 PM

We can see from the screenshot in the previous comment which is showing the Postman app, how they've decided to do it. Obviously, Keyrunner doesn't have to copy it pixel by pixel(!), but it can definitely serves as a great inspiration when coming from such a mature project..

frank-duq commented 1 month ago

One last thing while we're there (sry, again, let me know if you would rather treat this additional comment/feedback and the one from previous comment in a separate ui/ux enhancement / feat. req. ticket and I'll move those 2 items in a separate ticket..),

I find that the "side-by-side / horizontal" view is quite nice, I did not know it existed up until just very recently, discovered that bi-direction arrows icon to do it.

Having said that, I think the side-by-side UI could be improved a notch, to have things better aligned, to enhance the overall clarity of that great view.

For instance:

thanks!

launchiamenterprise commented 1 month ago

@frank-duq Thank you for the inputs. It’s helping us improve the overall UI/UX experience. We will be incorporating these improvements in upcoming releases

launchiamenterprise commented 4 weeks ago

@frank-duq We tried to incorporate all these changes in V#1.0.69, but encountered a last minute issue with the "beautify" feature. We are actively working on it and you can expect this feature in V#1.0.70.

frank-duq commented 3 weeks ago

Btw, here are 2 more feedbacks for this one:)

1- Suggestion to split the side-by-side nav menu (currently a drop-down, for both Request AND Response) into a mix of:

2- The side-by-side view, once selected, is 'not' persisted inside keyrunner's internal storage When I open a first request which displays the request/response vertically (default behavior, ok), and I then switch the layout to be "side-by-size / horizontal", and then I open a new/2nd request tab, then, 2 buggy outcomes imo:

a) my side-by-side layout selection is ignored by the new/2nd request tab, and is back at displaying my request/response layout vertically. IMO, the request/response layout selection should apply to ALL request tabs, it should be seen as a global user preference imo, not a per-request thing. A concrete scenario, is when I choose to execute an entire collection with the Console opened to monitor some execution details, then the default "vertical" view becomes irrelevant, since the Console is on top of the Response panel, by default.......so I like switching to horizontal/side-by-side layout in this case, for ALL my requests, without having to always switch the request/response layout for every single new request that I manually open for further investigation etc, while the Console is still opened over the top of the default Response panel, when in default vertical layout.

b) if I go back to my first opened request tab, its request/response layout got reset back to "vertical mode" even though I specifically selected the "horizontal" layout for this first request, just because I opened a 2nd request which currently opens in "vertical mode" by default (which I'm suggesting to change from previous point a) so perhaps fixing a) would automatically fix b) as well, but just so you know...)

cheers