Question: why not async?

launchql / pgsql-parser

PostgreSQL Query Parser for Node.js

MIT License

151 stars 24 forks source link

Question: why not async? #85

Closed acarl005 closed 2 years ago

acarl005 commented 2 years ago

Hi @pyramation, I have a question. I notice that the underlying libpg-query exposes both a sync and async entrypoint, parseQuerySync and parseQuery. However, pgsql-parser wraps the sync version but does not expose an async counterpart. Why is that? Is it for simplicity? Does the async version have no performance benefit?

pyramation commented 2 years ago

It just hasn't come up before. Do you want to expose it? Feel free to make a PR, I don't believe it changes the bundle size.

acarl005 commented 2 years ago

Implemented in #86