'--remove-image' is overriding error code of action

[davidferlay]

Observed

• Return code of action is lost when using --remove-image

➜ launchrctl platform:sync dev --username "XXX" --password "XXX" --vaultpass "XXX" --override xxxxxx; echo $?
Image "platform-actions-sync:latest" exists locally                  
OVERRIDDEN_COMPARISON_REF has been set: xxxxxx
Repository name: ski-platform
Last bump commit identified: xxxxxx
Attempting to download artifact: https://repositories.skilld.cloud/repository/ski-platform-artifacts/ski-platform-xxxxxx-plasma-src.tar.gz
ERROR: Artifact was not found
1

➜ launchrctl platform:sync dev --username "XXX" --password "XXX" --vaultpass "XXX" --override xxxxxx --remove-image; echo $?
Image "platform-actions-sync:latest" exists locally
OVERRIDDEN_COMPARISON_REF has been set: xxxxxx
Repository name: ski-platform
Last bump commit identified: xxxxxx
Attempting to download artifact: https://repositories.skilld.cloud/repository/ski-platform-artifacts/ski-platform-xxxxxx-plasma-src.tar.gz
ERROR: Artifact was not found
Image "platform-actions-sync:latest" was successfully removed
0

Expected

• Return code should depend on action return code, regardless of usage of --remove-image

➜ launchrctl platform:sync dev --username "XXX" --password "XXX" --vaultpass "XXX" --override xxxxxx --remove-image; echo $?
Image "platform-actions-sync:latest" exists locally
OVERRIDDEN_COMPARISON_REF has been set: xxxxxx
Repository name: ski-platform
Last bump commit identified: xxxxxx
Attempting to download artifact: https://repositories.skilld.cloud/repository/ski-platform-artifacts/ski-platform-xxxxxx-plasma-src.tar.gz
ERROR: Artifact was not found
Image "platform-actions-sync:latest" was successfully removed
1

[lexbritvin]

Fixed and merged to the main branch