lauqerm / ygocarder

A custom card maker for casual user who could not afford to use Photoshop.
15 stars 7 forks source link

Little Detail Fix Request #5

Open Sazer32 opened 2 days ago

Sazer32 commented 2 days ago

Hi, first of all, i'd like to say great work, I really love the software you made...

Then i'd like to point out a little wrong detail with the "1st Edition" button, the text always prints out in the bottom of the images near the Password field, when it should be just below the artwork (except for pendulum monster which is in the correct position):

image

image

image

In the first image is the product of your software, the second and third images are of a real card.

Also, a little suggestion/request, you could add the possibility to load the JSON that you can export from other card making websites, this way it's easier to migrate from one app to another instead of doing everything from scratch (most websites uses the same JSON files, which could make the job easier).

lauqerm commented 1 day ago

Hi there, the card you used for reference belong to an older series, which has the "1st Edition" mark below the artwork. Cards of the newer series (like "Mimighoul" for example), have consistent placement at the right of their passcode. image You can see the same for the latest reprint of Revival Jam here (in 2023), it is a Speed Duel card but you got the point. image

Still, if you really want to, I might add a small option to allow you to bring the 1st edition mark under the artwork just like the older series, it should be relative easy.

For the JSON part, could you tell me what is the website you want to load the JSON from? Each card maker site might use different structure without any common standard, so I will need sometime to see if this is feasible or not.

Sazer32 commented 1 day ago

hi, sorry for the false report and thank you for explaining the 1st edition thing (but the option to put it under the artwork would be a good addition).

For the JSON import/export

https://ygopro.org/yugioh-card-maker/ https://duelingnexus.com/yugioh-card-maker/ https://neocardmaker.com/index.php?/cardmaker/

These three sites use it, and probably use the same code since I can export from one site and import in another and all works fine (I'll put in a json you can use to test it and to use as a reference for the JSON format. Green-Eyes Defender.json )

EDIT: to notice that the artwork used is not originally foiled, the little foil traits on the artwork are made with https://duelingnexus.com/yugioh-card-maker/

lauqerm commented 1 day ago

Thanks you, it genuinely surprise me that these sites use the same format lol, it does make sense if they share the same "root" source code.

Anyway with a quick look into it, it seem they put the entire image data into the JSON file. This may cause some compatible problem since my app allow quick sharing by copy link, which only suitable for small JSON size. Let's see what I can come up with.