laura-313 / f1-3-c2p1-colmar-academy

0 stars 0 forks source link

SUMMARY #9

Open elisementor opened 7 years ago

elisementor commented 7 years ago

Grade: Satisfactory

Great job on this project. It looks beautiful and just like the wireframes. I love the fonts and colors you chose. Your code is very readable, clear, and logical. You have good comments but could add some more here and there.

The areas for improvement are minor, and mostly involve using universal classes for repeating styles, to reduce css repetition. Also use the mobile images provided for the second panel (practice). The thesis panel is the only one that needs a real tweak in its sizing proportions. Add a reset.css and a favicon. See my notes in your issues.

As extra challenges, you could make a set of media queries for tablets, and build out some more pages of the site using images you find on royalty free image sites like unsplash and pixabay.   You did a great job! Congrats.