search

lauraduncanson / icesat2_boreal

Biomass modeling and mapping of forest biomass in the boreal using NASA's ICESat-2
13 stars 6 forks source link

Remove Unused imports in python scripts #47

Closed wildintellect closed 3 years ago

wildintellect commented 3 years ago

While working on getting the 3.1.5 dps running I noticed many unused imports that had been copied over from notebooks. We need to audit the script to remove imports that are no longer used, and make sure a concise list of needed packages are listed for use in the DPS worker image creation (or in the DPS shell script for now).

Easy ones, anything related to show, plot etc... unless we are plotting to a file.

nmt28 commented 3 years ago

@pahbs can you take care of 3.1.5? I don't want to edit your code. I'll take care of 3.1.2 and 3.1.1

wildintellect commented 3 years ago

I already commented out bad imports in 3.1.5, still need to actually remove when sure. This ticket came from me doing that in order to get it to run on DPS.

wildintellect commented 3 years ago

3.1.2 is now changed by @nmt28 TODO - remove the unsused code, not just comment out. This applies to more than just the imports.

nmt28 commented 3 years ago

Done