I have created this draft PR to track the progress on refactoring of the mapBoreal_simple.R.
So far, the expansion around the growing season logic has been partitioned into smaller functions. Would be great to get your feedback, specially to make sure the logic has been refactored as intended.
Also, a basic test suite has been added to make sure any updates to the algorithms go through the tests before merge. So far the test coverage is pretty minimal and covers only the bits that I just added, but this hopefully will grow to the whole lib directory and then to the full repository. My hope is to setup CI/CD for the repository to do automated testing when PRs are submitted.
As a standard dev practice, it'd be good to requires all PRs to go through review and approval before being merged into the main branch.
I will keep working on this branch and try to keep the diffs small so it's easy to see what's being updated.
Hi!
I have created this draft PR to track the progress on refactoring of the mapBoreal_simple.R.
So far, the expansion around the growing season logic has been partitioned into smaller functions. Would be great to get your feedback, specially to make sure the logic has been refactored as intended.
Also, a basic test suite has been added to make sure any updates to the algorithms go through the tests before merge. So far the test coverage is pretty minimal and covers only the bits that I just added, but this hopefully will grow to the whole lib directory and then to the full repository. My hope is to setup CI/CD for the repository to do automated testing when PRs are submitted.
As a standard dev practice, it'd be good to requires all PRs to go through review and approval before being merged into the main branch.
I will keep working on this branch and try to keep the diffs small so it's easy to see what's being updated.
Best, -Ali