lauralex / dwm_lut

Apply 3D LUTs to the Windows desktop for system-wide color correction/calibration
GNU General Public License v3.0
252 stars 17 forks source link

do not support new windows 24H2 #60

Open Morindill opened 2 months ago

Morindill commented 2 months ago

it seems like the new ACM system crashed the APP

june-mg commented 2 months ago

i noticed after windows updated i could no longer get dwm_lut to work. only after i restored the prev version did it start working again

lauralex commented 1 month ago

It won't support 24h2 until it is generally available

lirtm commented 1 month ago

It won't support 24h2 until it is generally available

That's how it became public today.

notimp commented 1 month ago

It won't support 24h2 until it is generally available

Ran into the same problem. 24h2 went public today.

YuzuChii commented 1 month ago

im having the same issue so what can i do guys ? Screenshot 2024-10-05 003257

lirtm commented 1 month ago

im having the same issue so what can i do guys ? Screenshot 2024-10-05 003257

waiting for an update from the developer.

lauralex commented 1 month ago

Ok, gonna start updating the offsets. Let's hope it's the only thing that changes

lirtm commented 1 month ago

Ok, gonna start updating the offsets. Let's hope it's the only thing that changes

It will be great. Thank you very much!

lauralex commented 3 weeks ago

Ok, I finished reversing 24h2 offsets. I'll provide a release very soon

lirtm commented 3 weeks ago

Ok, I finished reversing 24h2 offsets. I'll provide a release very soon

Yay! Really looking forward to it!

lauralex commented 3 weeks ago

Support for 24H2 added. Looking for some real users testing. Unfortunately I tested with a VM, so I cannot actually see if the filter is applied (E.C. 1), but I don't have any errors. If you can give me feedback, I appreciate. ERRATA CORRIGE 1: I can see the color filter with the VM.

a3660537 commented 3 weeks ago

I used Release24h2 on 24H2. However, after this message , nothing happens. スクリーンショット 2024-10-23 130257

lirtm commented 3 weeks ago

Confirmed. After pressing Apply - the monitor goes out, but turns on faster than on 23H2, but the profiles are not applied. If you put it in autostart - because of the messages, probably, the system just hangs when probably starting the program, even Ctrl-Alt-Del does not work. Just the cursor, and nothing is applied.

lauralex commented 3 weeks ago

Did you install all C++ runtime dependencies? I think I'm gonna write it in the description, because they're needed

lirtm commented 3 weeks ago

Did you install all C++ runtime dependencies? I think I'm gonna write it in the description, because they're needed

Are there any add-ons for 24H2 that were not required for 23H2? I've been using it since June. I update OC all the time. Or are we talking about some additional plugins?

a3660537 commented 3 weeks ago

Did you install all C++ runtime dependencies? I think I'm gonna write it in the description, because they're needed

I installed https://www.techpowerup.com/download/visual-c-redistributable-runtime-package-all-in-one/ and I retried Release24h2 but the same message appeared

lauralex commented 3 weeks ago

https://github.com/lauralex/dwm_lut/commit/bb3a54061e640ebcb58d85636c2afc0330cd3e62 Ok I fixed the bug. I tested with the VM and I see the color filter applied. btw, those are just debug messages I leaved for testing

a3660537 commented 3 weeks ago

It worked ,thank you!

lauralex commented 3 weeks ago

I'll leave the issue open for a couple of days.

a3660537 commented 3 weeks ago

It worked ,thank you!

Strangely, It no longer works. Status is Active but actually inactive. I tried rebooting and deleting config.xml but it does not work.

And, on another 24h2 pc, when I click apply, display turns black for a moment and Status is still inactive.

Visual-C-Runtimes-All-in-One-Oct-2024 is installed on both.

KubaT1987 commented 3 weeks ago

Occasionally, the loaded LUT simply stops working with no error message. Restarting DWM LUT doesn't help.

notimp commented 3 weeks ago

For me on 24H2 the cursor just freezes for a bit, then the screen goes blank and comes in again (graphics driver resetting?), and the LUT status always stays on inactive. I'm trying to apply a SDR lut (attached), and my windows language version is german (unsure if that matters).

GPU is a GTX970 with current drivers (566.03). 27GL850SDR.zip

Visual C runtimes installed.

edit: The old version worked for me on previous windows builds, with the same lut.

I'm willing to test, or provide logs, if you need any.

edit: Same issue as this here:

And, on another 24h2 pc, when I click apply, display turns black for a moment and Status is still inactive.

lirtm commented 3 weeks ago

Both 4.0.0 and 4.0.1 still don't work. I specify the LUT, press Apply - the screen blinks once, and the status remains Inactive. I tried both the one downloaded only and the one launched without configuration at system startup

lauralex commented 3 weeks ago

You probably are using some kind of overlay tool, did you try disabling all possible programs that hijack the dwm?

a3660537 commented 3 weeks ago

You probably are using some kind of overlay tool, did you try disabling all possible programs that hijack the dwm?

I tried clean boot but dwmlut does not work.

lauralex commented 3 weeks ago

You probably are using some kind of overlay tool, did you try disabling all possible programs that hijack the dwm?

I tried clean boot but dwmlut does not work.

@a3660537 I think I may know the reason. Microsoft released another Windows 11 24H2 update exactly today. In fact, now the build number is 26100.2161. Previously it was 26100.2033. If DWM changes even with minor updates, it's gonna be a hell of a pain. Gonna find another sig scan strategy.

lirtm commented 3 weeks ago

You probably are using some kind of overlay tool, did you try disabling all possible programs that hijack the dwm?

Not a new program was added to the set of programs with which 3.9.6 worked.

lirtm commented 3 weeks ago

26100.2033

I just have 26100.2033 - and it doesn't work.

a3660537 commented 3 weeks ago

26100.2033

I just have 26100.2033 - and it doesn't work.

same

Edit:Just now I installed 26100.2161 and this error message appeared.

image
lauralex commented 3 weeks ago

Offsets updated to latest build 26100.2161. Uploading soon

lauralex commented 3 weeks ago

https://github.com/lauralex/dwm_lut/commit/f5268247e8d782db5d83e872ea97d34a3dd00f10

Tatted-Gamer93 commented 3 weeks ago

hello im still getting black screen when applying filter with the new update

notimp commented 3 weeks ago

Windows Defender detects Trojan:Script/Wacatac.B!ml on version 4.0.2 and autodeletes the file after a download.

https://www.microsoft.com/en-us/wdsi/threats/malware-encyclopedia-description?name=Trojan%3AScript%2FWacatac.B!ml&threatid=2147735503

Here is a virustotal.com log https://www.virustotal.com/gui/file/9e9b572dbf8049685c0a7d35a43a935486bc5df606068f30ea8ae65f469997c3?nocache=1

edit: Same hit on 4.0.1

lirtm commented 3 weeks ago

Windows Defender detects Trojan:Script/Wacatac.B!ml on version 4.0.2 and autodeletes the file after a download.

https://www.microsoft.com/en-us/wdsi/threats/malware-encyclopedia-description?name=Trojan%3AScript%2FWacatac.B!ml&threatid=2147735503

Here is a virustotal.com log https://www.virustotal.com/gui/file/9e9b572dbf8049685c0a7d35a43a935486bc5df606068f30ea8ae65f469997c3?nocache=1

edit: Same hit on 4.0.1

Yes, 4.0.2 Defender uninstalls immediately, as does the browser. 4.0.1 was downloaded but did not work.

lirtm commented 3 weeks ago

These are the errors when applying - I attach events from Event Viewer. Error.zip

Morindill commented 3 weeks ago

hello im still getting black screen when applying filter with the new update

Same issue with 26100.2161 & Ver.4.0.2

Tatted-Gamer93 commented 3 weeks ago

hello im still getting black screen when applying filter with the new update

Same issue with 26100.2161 & Ver.4.0.2

We are waiting for him to update it again

lauralex commented 3 weeks ago

It doesn't give me any black screen and the color filter is correctly applied and visible in my hyper-v windows machine with windows 11 24h2 2161. Gonna upload a debug version so that you can show me some debug messages here. If you want, you can compile it yourself with debug option and send me the messages. Also, you'd need to create a folder named DWMLOG in the C:\ path (i.e., C:\DWMLOG)

Morindill commented 2 weeks ago

I have to say the issue might not related to the DMW_Lut but the 24h2 itself, since any apps that are using dmw are not working. This includes lossless upscaling (frame generation) and RTSS (frame limiting). Idk what Microsoft does to the dmw but there are a lot of apps having compatibility issues (and also the new Black Ops 6 with frame generation on).

neverabyss commented 2 weeks ago
image

When I click OK, the program freezes for a few seconds, and then the screen turns black for a moment, as if the dwm.exe process had terminated and then automatically restarted. I used certutil -hashfile C:\Windows\System32\dwm.exe SHA256 to check dwm.exe hash sum and and got: f4351ca54628b830afa5accbf6e24a9cb89f0912187c7e1651f6130e5d84e920. My windows build: 26100.2161. dwm_lut.dll is built from the win24h2 branch in debug mode. dwm.log

lauralex commented 2 weeks ago
image

When I click OK, the program freezes for a few seconds, and then the screen turns black for a moment, as if the dwm.exe process had terminated and then automatically restarted. I used certutil -hashfile C:\Windows\System32\dwm.exe SHA256 to check dwm.exe hash sum and and got: f4351ca54628b830afa5accbf6e24a9cb89f0912187c7e1651f6130e5d84e920. My windows build: 26100.2161. dwm_lut.dll is built from the win24h2 branch in debug mode. dwm.log

Can you pass me the dwmcore.dll file? You can find it in the system32 directory. It seems that the swapchain that it gets is not valid.

KubaT1987 commented 2 weeks ago

Some of those problems might be caused by the overall bugginess of 24H2 (BSODs and other problems). Currently, the situation is so bad that Microsoft even had to block the update for some computers:

https://www.zdnet.com/article/microsoft-blocks-windows-11-24h2-update-for-some-pcs-following-bug-onslaught/

neverabyss commented 2 weeks ago

Can you pass me the dwmcore.dll file? You can find it in the system32 directory. It seems that the swapchain that it gets is not valid.

SHA256 hash of C:\Windows\System32\dwmcore.dll: 47eb01376561715145e3af652d661ceaec8b0fabc4d0eef670ce28a78792eba6

dwmcore.zip

casef commented 2 weeks ago

This includes lossless upscaling (frame generation) and RTSS (frame limiting)

You might want to update your RTSS, because the current version 7.3.6.28010 works just fine.

notimp commented 2 weeks ago

Here have my dwmcore.dll file as well:

SHA256-Hash of dwmcore.dll: 62f8c07003e15dfe02716f0a4a65d2a87cc0eb6770382a0813aae80a0340ea92 dwmcore.zip

In case you havent seen this one either.

EDIT by author: this one is for build 2033.

lauralex commented 2 weeks ago

Can you pass me the dwmcore.dll file? You can find it in the system32 directory. It seems that the swapchain that it gets is not valid.

SHA256 hash of C:\Windows\System32\dwmcore.dll: 47eb01376561715145e3af652d661ceaec8b0fabc4d0eef670ce28a78792eba6

dwmcore.zip

It's the same file I have in my VM. Very strange. I also tested right now and it works, with latest 24h2 build and latest updates.

image

lauralex commented 2 weeks ago

Can you install System Informer and send a screenshot of the results by searching "dwm" in the search bar? I need to check the "Session ID" column, so ensure that you added it in the selected columns. Here is an example: image

notimp commented 2 weeks ago

Status still inactive using 4.0.2 after trying to apply my lut (uploaded in here as a zip file before).

My OS Build is different (didnt install the optional octobre update yet (as most people would not, because it remains optional)) so there is a small chance, that all just starts working, once I'm on your build number or later.

osbuild

Here is the required screenshot of the session ID column in system informer (downloaded and used the portable version unsure if that matters).

sessionid

lauralex commented 2 weeks ago

Status still inactive using 4.0.2 after trying to apply my lut (uploaded in here as a zip file before).

My OS Build is different (didnt install the optional octobre update yet (as most people would not, because it remains optional)) so there is a small chance, that all just starts working, once I'm on your build number or later.

osbuild

Here is the required screenshot of the session ID column in system informer (downloaded and used the portable version unsure if that matters).

sessionid

Yeah, unfortunately I'm not gonna add support for previous minor build numbers. So, you'll have to stick with latest build number 2161. I hope that DWM doesn't change very often between minor updates, but we got unlucky this time.

notimp commented 2 weeks ago

Makes sense. I'll respond back once the update rolled out "normally". :)