laurencedawson / sync-for-lemmy

Issue tracker for the app Sync for Lemmy
114 stars 0 forks source link

Instance filter also filters posts & comments by users on other instances #320

Open Coffee-Viking opened 1 year ago

Coffee-Viking commented 1 year ago

Describe the bug
Filtering instance B (e.g. lemmynsfw.com) not only hides posts made in various communities on that instance as intended, but also hides posts and comments by registered users on instance B made to (allegedly harmless) communities on instance A (e.g. lemmy.world).

Steps to Reproduce

  1. Create an account with two instances, A and B
  2. Log in to your account with instance A, and filter instance B
  3. Switch to instance B, make a post and comment in instance A
  4. Switch back to instance A, refresh
  5. See nothing
  6. Remove instance filter for B, refresh feed
  7. Post is visible

Expected behavior
I'd expect to still posts and comments made to other instances, unless they are also on my instance filter.

Ideally, I would like to have an advanced filter setting with 3 swatches below the filtered instance (configurable for each individual filter):

  1. Hide all posts on instance (on/off)
  2. Hide all posts made to other instances (on/off)
  3. Hide comments from registered users (on/off)

Number 1 should be default ON (maybe ON only, so not a swatch), 2 and 3 OFF. While I don't personally see any use case where users would want 1 OFF and others ON, this might still be something users may want.

Screenshots
If applicable, add screenshots to help explain your problem.

Smartphone (please complete the following information): Device independent

Partially related to #293

laurencedawson commented 1 year ago

I kind of see instance filter as hiding content on that instance. It doesn't matter where it was posted from.

I'll leave this up for discussion.

chloyster commented 1 year ago

Personally I would really like to have the ability to completely block off a certain instance. To not see any of their posts or comments. After finding out that the built in lemmy instance blocking will be just for posts, I think having the option client side to totally hide an instance's content would be a good feature

Coffee-Viking commented 1 year ago

I kind of see instance filter as hiding content on that instance. It doesn't matter where it was posted from.

Users from some instances are known for excessive trolling, hating or simply having an ideology I don't agree with, so I'd love to have a way to filter them out as a whole (lemmygrad.ml [tankies], exploding-heads.com [lots of "free speech" thinly veiled racism], burgit.moe [trolling, barely legal anime porn] to name some) while for others it's sufficient to block posts on the instance (like any foreign language instances where users interact normally but merely in a way that I can't engage with. If they post or comment to other communities it's usually done in English, so that's something I don't mind at all.