laurencedawson / sync-for-reddit

New and improved issue tracker for the app Sync for Reddit
190 stars 3 forks source link

[BUG] Inline images cannot open more than once #968

Closed darius07 closed 2 years ago

darius07 commented 2 years ago

Describe the bug Inline images open correctly only once. The image cache must be manually cleared in order for the inline image to open again. Peaking on inline images works correctly multiple times, and inline gifs can be opened multiple times with no issues.

To Reproduce Steps to reproduce the behavior:

  1. Open a post containing inline images
  2. Click on an inline image
  3. Close the inline image
  4. Click again the same inline image
  5. Open the debug bottomsheet
  6. Inline image is stuck at: Submitting to the ImageManager

Expected behavior Inline images open correctly multiple times, without manually clearing the image cache after each inline image opening.

Screenshot and Video Example post: https://www.reddit.com/r/redditsync/comments/tmpmfr/v22324_beta_release/

The inline image is stuck at Submitting to the ImageManager Screenshot_20220331-110050

Video example: https://i.imgur.com/sW3idQG.mp4

Smartphone:

laurencedawson commented 2 years ago

Very strange, I've not had anyone else report this one at all.

Are you still having this issue?

darius07 commented 2 years ago

Yes, still having the same issue.

While troubleshooting this, I encountered another issue also solved by manually clearing the image cache. Tall images do not open (peaking works), or only open once. I have to clear the image cache, and the image can open successfully only once.

https://user-images.githubusercontent.com/12880926/161820933-45c54b56-c0c8-446c-8fa0-173725942dce.mp4

darius07 commented 2 years ago

I left the beta, and tried sync pro v19 again, and the issue is not present there. I can open inline and tall images more than once, without problems, and without manually clearing the image cache.

Rejoined the beta, and the issue came back on v22.3.28. I also have tried deleting the app data / cache from Android's app menu, reinstalling the app, trying login out and in, trying the Anonymous sync account, but nothing makes a difference.

laurencedawson commented 2 years ago

Still trying to replicate this!

darius07 commented 2 years ago

On the new V22.4.20 beta, I retested the issue, and even the resolution and size is not fetched properly when the images fails to load.

Inline image loading issue: Example inline image comment: https://www.reddit.com/r/redditsync/comments/u72362/v22420_beta_and_v19020_release/i5bwrlh/ 1) Image cache manually cleared 2) Inline image opens normally 3) Upon closing and re-opening the inline image, it is still stuck at Submitting to the ImageManager Screenshot_20220419-185640 Screenshot_20220419-185656

Tall image loading issue: Example tall image post: https://www.reddit.com/r/polandball/comments/u6zfnn/fables_but_its_ruined_by_countries 1) Image cache manually cleared 2) Tall image opens normally 3) Upon closing and re-opening the tall image, it is again stuck at Submitting to the ImageManager Screenshot_20220419-185439 Screenshot_20220419-185505

laurencedawson commented 2 years ago

I've added an additional error check for the next release. Fingers crosssed...

darius07 commented 2 years ago

No luck even on version v22.4.23-18. I have no clue what is causing it, but it seems linked to image caching, and reading from the image cache. Very weird that normal sized images do not suffer from it, only tall/inline images break and load infinitely.

I also tried this:

Screenshot_20220424-185203a

laurencedawson commented 2 years ago

Interesting. Thanks for the update.

On Sun, Apr 24, 2022 at 5:30 PM darius07 @.***> wrote:

No luck even on version v22.4.23-18. I have no clue what is causing it, but it seems linked to image caching, and reading from the image cache. Very weird that normal sized images do not suffer from it, only tall/inline images break and load infinitely.

I also tried this:

  • Opened the image in Sync Free v19.0.20 → Share image (Link) → Opens successfully first time in Sync Pro v22.4.23-18.
  • Shared the same image a second time from Sync Free v19.0.20 → Sync Pro v22.4.23-18, image loads infinitely.

[image: Screenshot_20220424-185203a] https://user-images.githubusercontent.com/12880926/164985838-67b2d207-9655-4557-8af0-0987886add5f.png

— Reply to this email directly, view it on GitHub https://github.com/laurencedawson/sync-for-reddit/issues/968#issuecomment-1107874341, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAECMKYPACC7DBZHRE6MBFDVGVZLPANCNFSM5SETBKDA . You are receiving this because you commented.Message ID: @.***>

laurencedawson commented 2 years ago

Follow up. Still having the issue?

Yet to get another report of this. Strange one.

darius07 commented 2 years ago

The issue still persists. It is very strange indeed.

Inline GIFs and image albums have no problem opening whatsoever once or 100 times, but a single inline image either cannot open at all (if cached) or only opens once (after it is cached).

Tall images behave similarly, if I open them just after they load, when scrolling down to load more posts, they open. The rest of the time I have to use image peek, if I want to see the tall image at all. Alternatively, I have to manually clear the image cache, but that still allows me to open any tall image only once.

laurencedawson commented 2 years ago

Next thing to try.

Can you disable this:

Settings > Animations > Image transitions

darius07 commented 2 years ago

No difference.

I also tried with all the toggles inside Animations disabled, tried different on/off toggles in Media, tried switching between the three options for Image Preloading (advanced) in Data Options, but still does not solve the issue.

laurencedawson commented 2 years ago

Are you based in the UK?

On Fri, Jun 17, 2022 at 6:03 AM darius07 @.***> wrote:

No difference.

I also tried with all the toggles inside Animations disabled, tried different on/off toggles in Media, tried switching between the three options for Image Preloading (advanced) in Data Options, but still does not solve the issue.

— Reply to this email directly, view it on GitHub https://github.com/laurencedawson/sync-for-reddit/issues/968#issuecomment-1158493028, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAECMK3WEGQDXCZH6NN6ZSLVPQBI5ANCNFSM5SETBKDA . You are receiving this because you commented.Message ID: @.***>

darius07 commented 2 years ago

Not based in UK, but in Europe. I have joined the Sync for Reddit Discord channel.

darius07 commented 2 years ago

It seems the issue is related to Android 6 and/or Lenovo Phab2's software. I do not have the issue any more on Android 12.