laurencee / Livestream.Monitor

A windows GUI for livestreamer/streamlink
GNU General Public License v2.0
59 stars 8 forks source link

Choosing the best quality problem #38

Closed Yersh closed 6 years ago

Yersh commented 6 years ago

Hi. Recently I found that twitch incorrectly marks the best quality available. In like 20-30% of streams you see something like:

[cli][info] Available streams: 160p (worst), 360p, 480p (best), 720p60, audio_only

To fix this I paste 1080p60,900p60,720p60,Best into quality field. It works, but after restarting Livestream.Monitor it goes back to Best.

Can you add a feature for saving custom quality setting for the Livestream.Monitor?

laurencee commented 6 years ago

~That feature was added in 2.11. https://github.com/laurencee/Livestream.Monitor/releases~

~If you're already on 2.11+ did you click save in the bottom right of the stream qualities page before you closed the window?~ ~https://i.imgur.com/2uVPUgE.png~ EDIT: See follow up message.

Also check if you're using livestreamer, if so the dev dropped support for that a while ago and you should move over to streamlink instead.

laurencee commented 6 years ago

Ah maybe I misunderstood what you were doing, the quality list is ordered so the entry at the top of the list is the one it'll try first so make sure you order the list from most important at the top to least important at the bottom.

I'll add a note for that priority ordering in a following release.

You don't need to put in "Best" or "Worst" at all because that's what the fallback quality option is for. It ensures that if all other options fail that you'll at least have something that should work.

laurencee commented 6 years ago

Made a release with some changes thanks to your feedback, let me know if this resolves your issue.

https://github.com/laurencee/Livestream.Monitor/releases/tag/2.11.2

Yersh commented 6 years ago

Sorry. I forgot to check for updates before writing. I was using 2.10.1 version. I updated to 2.11.2 and now everything works perfectly. Thank you.