'Hide stream output on load' stopped working

laurencee / Livestream.Monitor

A windows GUI for livestreamer/streamlink

GNU General Public License v2.0

59 stars 8 forks source link

'Hide stream output on load' stopped working #43

Closed Tharn closed 6 years ago

Tharn commented 6 years ago

Hi there,

Ever since Streamlink updated (I'm guessing this is why), the 'hide on load' option does not seem to work anymore. The console window does not hide when watching a stream or a VOD, but it does close when the media player closes.

laurencee commented 6 years ago

I'm running streamlink 0.13.0 which is the latest at the time of writing and don't appear to have this issue and am unsure how to replicate it.

Is there some specific stream this does it on? Does it happen for all of the stream providers? i.e. twitch/youtube/smashcast/mixer

Tharn commented 6 years ago

I tried both Twitch and Mixer for this, so that means several streams and several providers.

I also think that I had the option set, then un-ticked the box on the console output one time.. after which neither option nor the tick box work anymore. I didn't think that was the reason and assumed it had to be some update.

Will test this some more later.

Tharn commented 6 years ago

It still doesn't work. I have been looking at the config file, and "HideStreamOutputMessageBoxOnLoad": true, should correspond with the LM setting? There is no other way this setting could permanently screw itself, right?

Also, playing around with this I noticed the checkbox on the console output does not always set the setting correctly, i.e.:

Disable Hide Stream Output On Load, then load a VOD -> checkbox is not marked.
Disable Hide Stream Output On Load, then load a VOD and mark the checkbox -> Setting is still disabled. If you close the VOD and enable the setting, the Save option acts as if it was enabled all along.
Enable Hide Stream Output On Load, then load a VOD -> checkbox is marked.
Enable Hide Stream Output On Load, then load a VOD and unmark the checkbox -> Setting is still enabled. If you close the VOD and disable the setting, the Save option acts as if it was disabled all along.

Tharn commented 6 years ago

An example of the console output:


'streamlink.exe --player-passthrough hls https://www.twitch.tv/user/v/273569695 720p60,720p30,720p,Best --twitch-oauth-token *token goes here*'
[console][info] Found matching plugin twitch for URL https://www.twitch.tv/user/v/273569695
[plugin.twitch][info] Attempting to authenticate using OAuth token
[plugin.twitch][info] Successfully logged in as *Username*
[console][info] Available streams: audio, 160p (worst), 360p, 480p, 720p, 720p60, 1080p60 (best)
[console][info] Opening stream: 720p60 (hls)
[console][info] Starting player: "C:\Program Files\MPC-HC\mpc-hc64.exe"

laurencee commented 6 years ago

Ohh I think i see the issue

if (args.Data.StartsWith("[cli][info] Starting player") ...) https://github.com/laurencee/Livestream.Monitor/blob/master/Livestream.Monitor/Model/StreamLauncher.cs#L246

For some reason the output of your streamlink is different than the output of mine. I guess I can just look for "Starting player" instead for now to sort that out for you and anyone else who might have this issue.

laurencee commented 6 years ago

https://github.com/laurencee/Livestream.Monitor/releases/tag/2.11.4