laurencee / Livestream.Monitor

A windows GUI for livestreamer/streamlink
GNU General Public License v2.0
59 stars 8 forks source link

Long VOD titles displace info #54

Closed Tharn closed 7 months ago

Tharn commented 4 years ago

I can confirm this with Twitch so far. VOD titles with several line breaks may push the video duration & recorded date down and out of view on the VOD button.

Would recommend only allowing 3 lines of title text so that the other two still have room.

laurencee commented 7 months ago

Any idea if this is still an issue? Twitch changed how they returned data a while back but I don't know if they still send through line breaks in titles of vods that cause issues.

Tharn commented 7 months ago

I just checked, and.. Clipboard-1

If you want to check it, this is on Page 2 of Broadcasts of old Twitch streamer Jefmajor. Interestringly, titles are not particularly long for this broadcast.

Lots of misplaced info on Page 5 of his Broadcasts as well. Clipboard-2

If you'll take a suggestion, I would condense the two bottom infos by removing the line break between them, giving the top stuff one more line, and then fading out the rest of it if it's too long.

laurencee commented 7 months ago

I have a fix for this on an old branch that I never ported across, but couldn't find a stream to repro to see if I needed to port it over. Cheers.

laurencee commented 7 months ago

https://github.com/laurencee/Livestream.Monitor/releases/tag/2.13.9

laurencee commented 7 months ago

Actually still has an issue I gotta sort out...

laurencee commented 7 months ago

Found that twitch seems to allow embeding both windows and linux styles of linebreaks, so I need to handle stripping out both. Should be good now, page 5 of Jefmajor's vods looks correct to me.