search

laurencee / Livestream.Monitor

A windows GUI for livestreamer/streamlink
GNU General Public License v2.0
59 stars 8 forks source link

Top Streams -> Game Filter issues #58

Closed Tharn closed 3 years ago

Tharn commented 4 years ago

(This is for Twitch.TV)

When using the Top Streams & Game Filter options, LM will correctly show the first 15 streams ordered by viewers. It will not show the country flags anymore, and using the < > buttons at the bottom will not flick pages anymore but will load the same 15 streams every time.

laurencee commented 4 years ago

Thanks, the newer twitch api being used does paging significantly differently than the old one so I'll need to figure out a good way to handle it.

The old one was just just requesting a number of items and the current offset (how many items to skip). The new one you need to provide some unique paging id to go to the next page so I'll have to store that in the twitch provider while you're on the top streams tab (and clear correctly on leaving).

Tharn commented 4 years ago

With v. 2.12.9, I can't get any top streams filtered by game anymore. It just gives me this:

Untitled

laurencee commented 4 years ago

Cheers, I'll take a look at it soon.

laurencee commented 3 years ago

Sorry I've been away for a while but I'm back again now and have this fixed locally, will push a release out soon.

Tharn commented 3 years ago

Thanks for the fix! Unfortunately the 'page buttons do nothing' thing still persists.

laurencee commented 3 years ago

Yep that's a separate issue than what was fixed. When I came back to look at this I only noticed the obvious error message when entering an unknown game name.

Could you create a github issue just specific to that paging problem? It requires a fair bit of effort to fix compared to this stuff that was done.

laurencee commented 3 years ago

Forgot to mention that I had also fixed the flag issue but hadn't checked in that for the last release.