search

laurencee / Livestream.Monitor

A windows GUI for livestreamer/streamlink
GNU General Public License v2.0
60 stars 8 forks source link

Change Page functionality broken #62

Closed Tharn closed 3 years ago

Tharn commented 4 years ago

Making a separate bug report as per request!

Using the Page function, both on VODs, on Top Streams and on Top Streams with Game Filter on, clicking the < and > buttons will change the Page counter and make the stream list reload without actually changing the stream list. I.e. for all these things, the only page that is accessible is page 1.

laurencee commented 3 years ago

It's working now except for top streams that happen to be reruns due to a twitch api bug.

The bug manifests when I ask twitch for N top streams, 1 (or more) of them is a rerun so twitch drops it from the response but only returns N-1 streams instead of adding another one that isn't a rerun.

Either twitch should be including the rerun stream in the list returned (makes sense given there's no option in the request to include/exclude these) or twitch should be including the next highest non-rerun stream to the response.

When this bug occurs livestream monitor thinks it's on the last page of data given twitch hasn't returned enough entries to fill a full page so livestream monitor disables the next page button.

Tharn commented 3 years ago

Cheers. Working fine for Top Streams now. VOD lists still only display the same single page.

laurencee commented 3 years ago

Can try the newest release, should fix that too.

Tharn commented 3 years ago

I did, it's all fixed now.