search

laurencelundblade / QCBOR

Comprehensive, powerful, commercial-quality CBOR encoder/ decoder that is still suited for small devices.
Other
183 stars 47 forks source link

Adds ARM coding style useful buf #161

Closed adam2809 closed 1 year ago

adam2809 commented 2 years ago

This is already in t_cose but I think it makes more sense to put it in here.

laurencelundblade commented 2 years ago

If I were doing QCBOR over again, I would use the linux/arm style as I have come to like it better. But...

All of QCBOR is in a consistent style that is not the arm/linux style. I don't think adding this one file to QCBOR makes sense because QCBOR would now be in two styles. It would add confusion for most people using QCBOR.

Maybe in the long run there could be a project to have the entire QCBOR API be linux/arm style, but that would be a big job and both styles of API would pretty much have to be supported forever.

davidvincze commented 1 year ago

If I were doing QCBOR over again, I would use the linux/arm style as I have come to like it better. But...

All of QCBOR is in a consistent style that is not the arm/linux style. I don't think adding this one file to QCBOR makes sense because QCBOR would now be in two styles. It would add confusion for most people using QCBOR.

Maybe in the long run there could be a project to have the entire QCBOR API be linux/arm style, but that would be a big job and both styles of API would pretty much have to be supported forever.

Hi Laurence, If your last comment is still valid (I'm sure it is), may I ask you to close/abandon this PR? Thank you!

laurencelundblade commented 1 year ago

Not merging this to keep QCBOR simpler and cleaner and in just one coding style.