add "shortcut icon" in condition while fetching the favicons - Githubissues

laurengarcia / url-metadata

NPM module: Request a url and scrape the metadata from its HTML using Node.js or the browser.

https://www.npmjs.com/package/url-metadata

MIT License

166 stars 43 forks source link

add "shortcut icon" in condition while fetching the favicons #88

Closed heyarviind closed 2 months ago

heyarviind commented 2 months ago

Check one:

[ ] I am reporting a bug.
[ ] I am requesting a feature.

Steps to reproduce (if bug):

1. 2.

Feature request:

Please attach screenshots here if helpful

Checklist:

[ ] update README (if applicable)
[ ] update CHANGELOG
[ ] update ROADMAP (if applicable)
[ ] index.d.ts: ensure parameters, options & Result are still correct
[ ] npm run test
[ ] /example-typescript: npm run start
[ ] package.json: bump version

laurengarcia commented 2 months ago

Looks good to me. For posterity: https://stackoverflow.com/questions/13211206/html5-link-rel-shortcut-icon

laurengarcia commented 2 months ago

Version 4.1.1 now available: https://www.npmjs.com/package/url-metadata