Pseudocode Review

[daytonamelia]

Very clean pseudocode! It makes a lot of sense to me.

My feedback:

• I like your inputs! I like the option for a threshold a lot and will probably steal that input idea from you 😅
• I like the use of a set for the indexes - I always forget about them but that's such a great use of them.
• I'm not sure if you want to edit the input files with 'a' ... but you definitely want to use 'append' for the outputs!
• You should build in a cases for an "N" in the index (I also forgot this!)

Great work! Makes a lot of sense to me :)

[calzamora]

Your code is beautiful!

Pseudocode: I think the way that you're populating the mismatched dict in order to track the index combinations is really smart and I'll probably steal that idea! I think your idea to edit the headers before looping through will definitely make populating headers down the line easier. My only question is if this will take extra time? I actually am not sure if its more efficient to do it here or when youre populating files.

Planned functions: These are all great ideas and the same functions I had thought about making as well.

Do you think that the convert qscore function that you're wrapping in check_qscore should work for +64 and +33? This is something I've been debating as well - these files are all +33 so the established function we have will work but maybe it would be worth broadening the scope long term? I haven't decided on this yet so I'm actually super curious on your thoughts!