Closed ddanilko-sonova closed 3 years ago
No, you are wrong, this is not an incompatible change. Graham Dumpleton is very meticulous and would not allow himself this kind of mistake.
The real problem is that there is no wheel available for Python 2.7 on Windows (but there are some for Python >= 3.5). He says that this is due to a compilation issue with GitHub Action.
2 solutions:
Sorry, but I won't accept the PR.
Problem statement
According to https://github.com/tantale/deprecated/blob/f5eebcddaebf2dafd3f734e85c4c85cbbae9aef4/setup.py#L161 the
deprecated
package depends on thewrapt
package (most recent1.*
-compatible version).Unfortunately, the
wrapt
package does not follow semantic versioning which means that the installation of thedeprecated
package might fail if a new1.*
release of thewrapt
package comes out. This is what happened recently with the release of version 1.13.0 ofwrapt
not being able to install on Windows+Python2.7. For details refer to https://github.com/GrahamDumpleton/wrapt/issues/189. Unfortunately, the developers ofwrapt
do not plan to adhere to semantic versioning, which means that fordeprecated
to work reliably for its users, it might be a good idea to adapt the version specification of thewrapt
package.Possible solution
First, pin the version of
wrapt
to==1.12.1
and releasedeprecated
as1.2.14
Then pin the version ofwrapt
to==1.13.1
and releasedeprecated
as2.0.0
, stating that the support for Python2.7 on Windows is dropped or drop support for Python 2.7 on all platforms (as it might be difficult to specify the combination with Windows in the setup scripts...)Alternatives considered
After releasing
deprecated v1.2.14
withwrapt==1.12.1
, one could consider unpinning wrapt again (wrapt<2
), however, given thatwrapt
does not adhere to semantic versioning, this should be considered dangerous (e.g. they consider dropping support for Python2.7 in 1.14.0).Reproduction steps
Make sure that you do not have
wrapt
installed. Installdeprecated
on Windows+Python2.7Expected Behavior
The installation succeeds.
Actual Behavior
The installation fails with the following error:
Environment