search

laurent22 / joplin

Joplin - the secure note taking and to-do app with synchronisation capabilities for Windows, macOS, Linux, Android and iOS.
https://joplinapp.org
Other
43.68k stars 4.71k forks source link

Desktop: Note attachments screen: Allow searching for attachments #10442

Closed personalizedrefrigerator closed 1 week ago

personalizedrefrigerator commented 2 weeks ago

Summary

This pull request adds a "search" input to the note attachments screen that allows filtering attachments by ID and title.

[!NOTE]

This was originally implemented a few months ago to help debug #10052. A pull request has been opened now in response to this feature being requested on the forum.

Screen recording

https://github.com/laurent22/joplin/assets/46334387/3cb703fc-4339-4c95-84fb-a0beff1a6974

Testing plan

This pull request has been tested manually by:

  1. Creating a large number of resources:
    • This was done from Joplin's development tools with code similar to: 
      for (let i = 0; i < 10000; i++) {
await Resource.save({ title: "Test 2." + i, mime: "text/plain" });
console.log('created', i);
}
  2. Opening Tools > Note attachments
  3. Searching for "Test"
  4. Copying part of the ID of a resource.
  5. Searching for that ID.