search

laurent22 / joplin

Joplin - the privacy-focused note taking app with sync capabilities for Windows, macOS, Linux, Android and iOS.
https://joplinapp.org
Other
45k stars 4.89k forks source link

“Alt + ←” for back navigation collides with a built-in shortcut of notes sort order #10545

Open heliole opened 3 months ago

heliole commented 3 months ago

Operating system

Windows

Joplin version

2.14.22

Desktop version info

Joplin 2.14.22 (prod, win32)

Sync Version: 3 Profile Version: 46 Keychain Supported: Yes

Backup: 1.4.0

Current behaviour

The Back keyboard shortcut (set to “Alt + ←”) works fine unless a note in the Notes List is in focus, also I can still click outside of any note somewhere in the Notes List window and use the shortcut and it will work fine, but if the focus is on a note tile in the notes list:

1st Case - note sort order isn't set to Custom order: it shows a dialog: "To manually sort the notes, the sort order must be changed to "Custom order" in the menu "View" > "Sort notes by""

2nd Case - note sort order is set to Custom order: both Back and Forward shortcuts unexpectedly move the focused note list item up, unless it's atop the list

Expected behaviour

Back and forward keyboard shortcuts work fine regardless what is in focus.

Logs

No response

personalizedrefrigerator commented 2 months ago

This issue is likely caused by the .preventDefault on this line:

https://github.com/laurent22/joplin/blob/a0e3e4fefb4beb7830d34b65ba47f327edbd8c70/packages/app-desktop/gui/NoteList/utils/useOnKeyDown.ts#L86

github-actions[bot] commented 1 month ago

Hey there, it looks like there has been no activity on this issue recently. Has the issue been fixed, or does it still require the community's attention? If you require support or are requesting an enhancement or feature then please create a topic on the Joplin forum. This issue may be closed if no further activity occurs. You may comment on the issue and I will leave it open. Thank you for your contributions.

heliole commented 1 month ago

Update Joplin 3.0.12: Now the sort order is no longer being triggered, instead nothing is happenning when the note tile is in focus. The desired behaviour would be that the back and forward navigation still works when a note tile is in focus, and not only when it's body(editor) is in focus.

github-actions[bot] commented 3 weeks ago

Hey there, it looks like there has been no activity on this issue recently. Has the issue been fixed, or does it still require the community's attention? If you require support or are requesting an enhancement or feature then please create a topic on the Joplin forum. This issue may be closed if no further activity occurs. You may comment on the issue and I will leave it open. Thank you for your contributions.

heliole commented 3 weeks ago

Update Joplin 3.0.14: The old behaviour is back.