search

laurent22 / joplin

Joplin - the secure note taking and to-do app with synchronisation capabilities for Windows, macOS, Linux, Android and iOS.
https://joplinapp.org
Other
44.09k stars 4.77k forks source link

F-droid build doesn't have "take picture" feature #10573

Open Th3-A6add0n opened 2 weeks ago

Th3-A6add0n commented 2 weeks ago

Operating system

Android

Joplin version

3.0.3

Desktop version info

No response

Current behaviour

When I clicked on "take picture" it doesn't work & neither does it ask for camera permissions. Screenrecording

Expected behaviour

When clicked on "take pictures" it should open up the camera to take pictures.

Logs

No response

JackGruber commented 2 weeks ago

Yes as mentioned in the description page, the F-Droid app doesn't have the camera feature. https://github.com/laurent22/joplin/pull/5735

Th3-A6add0n commented 2 weeks ago

Yes as mentioned in the description page, the F-Droid app doesn't have the camera feature. #5735

How does getting a camera access depend on play services or firebase?

personalizedrefrigerator commented 2 weeks ago

How does getting a camera access depend on play services or firebase?

Among other libraries, react-native-camera (on a list of libraries we may want to replace) depends on Google Play Services for barcode scanning and face detection (I think we use neither of these aspects of react-native-camera):

  implementation "com.google.android.gms:play-services-mlkit-text-recognition:16.3.0"
  generalImplementation "com.google.android.gms:play-services-mlkit-barcode-scanning:16.2.0"
  generalImplementation "com.google.android.gms:play-services-mlkit-face-detection:16.2.0"
  mlkitImplementation "com.google.mlkit:barcode-scanning:16.2.0"
  mlkitImplementation "com.google.mlkit:face-detection:16.1.2"