Open vassudanagunta opened 2 months ago
Based on packages/turndown/package.json
, it seems that only the CJS version of the library is built in CI:
https://github.com/laurent22/joplin/blob/8eda8d3c849c01b5f3c79662afaf004e434d61b1/packages/turndown/package.json#L44
https://github.com/laurent22/joplin/blob/8eda8d3c849c01b5f3c79662afaf004e434d61b1/packages/turndown/package.json#L50
The prepare
step might need to be changed to npm run build-all
to support ESM.
Hey there, it looks like there has been no activity on this issue recently. Has the issue been fixed, or does it still require the community's attention? If you require support or are requesting an enhancement or feature then please create a topic on the Joplin forum. This issue may be closed if no further activity occurs. You may comment on the issue and I will leave it open. Thank you for your contributions.
This is still a needed fix. I hesitate to take a stab at it as I don't (yet) use Joplin and I not sure I can do the update safely without breaking the primary client (Joplin).
Hey there, it looks like there has been no activity on this issue recently. Has the issue been fixed, or does it still require the community's attention? If you require support or are requesting an enhancement or feature then please create a topic on the Joplin forum. This issue may be closed if no further activity occurs. You may comment on the issue and I will leave it open. Thank you for your contributions.
Yes, this really ought to be fixed. @personalizedrefrigerator seems to know what's what. I was hoping it would happen. I'm not familiar at all with the codebase and build system, otherwise I'd make a PR.
Operating system
macOS
Joplin version
latest
Desktop version info
No response
Current behaviour
results in
The same thing happens for
@joplin/turndown-plugin-gfm
.Expected behaviour
Looking in the
node_modules/@joplin/turndown
, I only seeturndown.cjs.js
, not the.es.mjs
version that the package.json build script mentions.I was hoping to use your version of Turndown.js!
Logs
No response