laurent22 / joplin

Joplin - the privacy-focused note taking app with sync capabilities for Windows, macOS, Linux, Android and iOS.
https://joplinapp.org
Other
45.82k stars 4.98k forks source link

Android trash icon is an emoji instead #11202

Open SidonieBouthors opened 2 weeks ago

SidonieBouthors commented 2 weeks ago

Operating system

Android

Joplin version

3.0.8

Desktop version info

No response

Current behaviour

  1. Install Joplin
  2. Open sidebar
  3. All icons are flat icons in the same style, but the trash icon is an emoji instead

image

Expected behaviour

I expected all icons to be in a similar or coherent style. This is the only one that is an emoji as far as I can tell.

Logs

No response

SidonieBouthors commented 2 weeks ago

On a similar note, I also just installed Joplin on Pop!_OS and although the icon is not an emoji, the trash icon also looks different from all the others (it is a filled icon in a different style, instead of outline icons), but not sure if that is related.

Desktop version info :

Joplin 3.0.15 (prod, linux)

Client ID: 9637ac3d343843ad9f3d9d74baf57297 Sync Version: 3 Profile Version: 47 Keychain Supported: No

Current Behavior :

image

mrjo118 commented 1 week ago

The icons for trash are clearly by design, but I guess you are questioning the choice of icons. I see your point on the desktop app about it not being entirely consistent, but to be honest I didn't notice until you mentioned it.

I would agree on the android app though that the emoji did seem out of place when the trash feature first appeared.

SidonieBouthors commented 1 week ago

Fair enough. The icon difference on desktop isn't too noticeable I just added it in case it was somehow related :) On android though I noticed it immediately (it also doesn't look good in dark mode since it doesn't change color like the other icons). I suppose if it wasn't changed earlier, it may have been a design choice to have it this way, but I can't quite understand what would be the use of bringing attention to the trash icon in particular.