laurent22 / joplin

Joplin - the privacy-focused note taking app with sync capabilities for Windows, macOS, Linux, Android and iOS.
https://joplinapp.org
Other
46.35k stars 5.04k forks source link

AppImage icon is broken in basic setup #11214

Open zach-delong opened 1 month ago

zach-delong commented 1 month ago

Operating system

Linux

Joplin version

3.0.15

Desktop version info

Joplin 3.0.15 (prod, linux)

Client ID: 64c113d6fca244a28e7ddd65fb041570 Sync Version: 3 Profile Version: 47 Keychain Supported: No

Revision: 598677b

Backup: 1.4.1

Extra information about my system to help debugging: Screenshot from 2024-10-15 15-08-40

Current behaviour

Expected behaviour

I expect the icons to appear everywhere and not just in the AppImage's properties.

Logs

I don't think there are any logs relating to this, though I'll follow any instructions to grab anything.

zach-delong commented 1 month ago

Update: I reinstalled using the suggested script and I still have the same broken icon on my dock. :thinking:

Iss-in commented 1 month ago

problem is that its app_id has '/' character in its name, appid is whats used to pick icon for a window, and it is causing issues

zach-delong commented 1 month ago

I did some more debugging and noticed that my desktop (also running Fedora 40) doesn't have this issue, so I kept digging in. I have the icon at ~/.local/share/icons/hicolor/512x512/apps/joplin.png and in my desktop icon file I have

[Desktop Entry]
Encoding=UTF-8
Name=Joplin
Comment=Joplin for Desktop
Exec=env APPIMAGELAUNCHER_DISABLE=TRUE "/home/zachery/.joplin/Joplin.AppImage"  %u
Icon=joplin
StartupWMClass=Joplin
Type=Application
Categories=Office;
MimeType=x-scheme-handler/joplin;
X-GNOME-SingleWindow=true // should be removed eventually as it was upstream to be an XDG specification
SingleMainWindow=true

So the icon and the image appear to exist in the right places, but I'm not sure why they aren't connecting yet.

problem is that its app_id has '/' character in its name, appid is whats used to pick icon for a window, and it is causing issues

I would expect this is probably why the appimage itself doesn't have the right icon, but the "installer script" that I fell back to when the appimage didn't behave as expected seems to my untrained eye to account for this by setting up its own .desktop file that manually specifies.

Iss-in commented 1 month ago

gnome uses startup-wm class to find icon i think, hence its correct in fedora, but other wms, specially wlroots, they use app_id only, hence the issue in them

zach-delong commented 1 month ago

hence its correct in fedora

Both of my computers are Fedora, but one of them (my laptop) is showing the broken icon, which is strange. I was just using my laptop as normal and installed something (wine) and the icon magically fixed itself. I am not sure why the icon would just fix itself during install but not during reboot, but apparently something got shaken loose...

github-actions[bot] commented 3 days ago

Hey there, it looks like there has been no activity on this issue recently. Has the issue been fixed, or does it still require the community's attention? If you require support or are requesting an enhancement or feature then please create a topic on the Joplin forum. This issue may be closed if no further activity occurs. You may comment on the issue and I will leave it open. Thank you for your contributions.