search

laurent22 / joplin

Joplin - the privacy-focused note taking app with sync capabilities for Windows, macOS, Linux, Android and iOS.
https://joplinapp.org
Other
46.36k stars 5.04k forks source link

Dark mode not respected by "Sort notes by" #4672

Open Jonta opened 3 years ago

Jonta commented 3 years ago

Environment

Joplin version: 1.7.5, Database v34, FTS enabled: 1 Platform: Android OS specifics: 10

Steps to reproduce

  1. Configuration -> Appearance -> Theme -> OLED Dark
  2. Darkness appears
  3. Back to start-screen
  4. Tap 3-horisontal-line menu-button top right
  5. White background

Describe what you expected to happen

Dark background

Logfile

No errors in Configuration -> Log

vikas-kundu commented 3 years ago

@roman-r-m I wish to work on this. I am a beginner. Can you let me know the location of theme files in your codebase ?

roman-r-m commented 3 years ago

I suppose it's https://github.com/laurent22/joplin/blob/ccbc329cbf806e9b6db6d37f8c837629ee6c3a60/packages/lib/theme.ts

vikas-kundu commented 3 years ago

@roman-r-m So i checked this. Turns out that the sort dialog does not obey any of the themes for mobile app only. Whereas for desktop app, the sort option obeys theme rules. So, it looks that perhaps the element has been created differently for mobile app. I am not well versed with android app development so could you please guide me how the sort dialog is formed for joplin mobile app?

roman-r-m commented 3 years ago

the element has been created differently for mobile app

Probably, yes. Most UI elements are different between desktop and mobile.

I am not well versed with android app development so could you please guide me how the sort dialog is formed for joplin mobile app?

What have you tried so far? A simple search for "sort" in packages/app-mobile should give you the result.

Jonta commented 3 years ago

Related: Same with prompt "Delete these notes?"

Possibly related: https://github.com/laurent22/joplin/issues/4450

Jonta commented 3 years ago

Possibly related: Long-press in a note does not respect system's dark-mode (for popup of e.g. "Paste" and "Select all")

Thanks for taking on the issue, and tell me if these are not related, and should be separate issues instead. =)

roman-r-m commented 3 years ago

If I recall correctly, the long-press & "delete these notes" dialogs are the same component, and it's different from the one used for the sort order (i.e. this issue).

vikas-kundu commented 3 years ago

@roman-r-m there seems to be many issues with themes in mobile app. It seems they will need to be redesigned for mobile app keeping other components in mind. I am unable to find the any sort component in the app-mobile folder. My knowledge is limited and I am new to the codebase

roman-r-m commented 3 years ago

there seems to be many issues with themes in mobile app. It seems they will need to be redesigned for mobile app keeping other components in mind.

While I do agree that UI on mobile is sometimes inconsistent (and plain ugly at times), what's your suggestion? If you'd like to redesign all of it, this might be too much for the 1st task. Otherwise, if you don't want to fix this issue, you're free to pick something else.

I am unable to find the any sort component in the app-mobile folder. My knowledge is limited and I am new to the codebase

Again, what have you tried to find it? Keep in mind, there may not be a separate component, might be a part of a bigger UI element.

vikas-kundu commented 3 years ago

@roman-r-m so i did some digging around and i was able to find:

Will take me some time but i am positive i will fix it in a few days.

vikas-kundu commented 3 years ago

I have connected my phone via USB for debugging but still getting this error: warn No apps connected. Sending "devMenu" to all React Native apps failed. Make sure your app is running in the simulator or on a phone connected via USB. Moreover running into errors while building from android studio. Is there a development guide for building the mobile app?

stale[bot] commented 3 years ago

Hey there, it looks like there has been no activity on this issue recently. Has the issue been fixed, or does it still require the community's attention? This issue may be closed if no further activity occurs. You may comment on the issue and I will leave it open. Thank you for your contributions.

Jonta commented 3 years ago

Still requires the community's attention

stale[bot] commented 3 years ago

Hey there, it looks like there has been no activity on this issue recently. Has the issue been fixed, or does it still require the community's attention? This issue may be closed if no further activity occurs. You may comment on the issue and I will leave it open. Thank you for your contributions.

Jonta commented 3 years ago

Still requires the community's attention

stale[bot] commented 3 years ago

Hey there, it looks like there has been no activity on this issue recently. Has the issue been fixed, or does it still require the community's attention? This issue may be closed if no further activity occurs. You may comment on the issue and I will leave it open. Thank you for your contributions.

Jonta commented 3 years ago

Still requires the community's attention

Joplin 2.1.4 - Database v39

Jonta commented 3 years ago

@vikas-kundu https://github.com/laurent22/joplin/blob/dev/BUILD.md I think

stale[bot] commented 3 years ago

Hey there, it looks like there has been no activity on this issue recently. Has the issue been fixed, or does it still require the community's attention? This issue may be closed if no further activity occurs. You may comment on the issue and I will leave it open. Thank you for your contributions.

Jonta commented 3 years ago

Still requires the community's attention

Joplin 2.4.3 - Database v39

Jonta commented 3 years ago

@stale Why aren't you removing the label?

stale[bot] commented 3 years ago

Hey there, it looks like there has been no activity on this issue recently. Has the issue been fixed, or does it still require the community's attention? This issue may be closed if no further activity occurs. You may comment on the issue and I will leave it open. Thank you for your contributions.

Jonta commented 3 years ago

Still requires the community's attention

Joplin 2.4.3 - Database v39

Jonta commented 3 years ago

@laurent22 Label as good first issue perhaps? =)

github-actions[bot] commented 2 years ago

Hey there, it looks like there has been no activity on this issue recently. Has the issue been fixed, or does it still require the community's attention? This issue may be closed if no further activity occurs. You may comment on the issue and I will leave it open. Thank you for your contributions.

Jonta commented 2 years ago

Still requires the community's attention

Joplin 2.6.8 - Database v41

@laurent22 Poke. :)

Jonta commented 2 years ago

@github-actions @stale Remove the label

github-actions[bot] commented 2 years ago

Hey there, it looks like there has been no activity on this issue recently. Has the issue been fixed, or does it still require the community's attention? This issue may be closed if no further activity occurs. You may comment on the issue and I will leave it open. Thank you for your contributions.

Jonta commented 2 years ago

Still requires the community's attention

Joplin 2.6.8 - Database v41

github-actions[bot] commented 2 years ago

Hey there, it looks like there has been no activity on this issue recently. Has the issue been fixed, or does it still require the community's attention? This issue may be closed if no further activity occurs. You may comment on the issue and I will leave it open. Thank you for your contributions.

Jonta commented 2 years ago

Still requires the community's attention

Joplin 2.7.2 - Database v41

@laurent22 Please label this so I don't have to keep updating this

github-actions[bot] commented 2 years ago

Hey there, it looks like there has been no activity on this issue recently. Has the issue been fixed, or does it still require the community's attention? This issue may be closed if no further activity occurs. You may comment on the issue and I will leave it open. Thank you for your contributions.

Jonta commented 2 years ago

Still requires the community's attention

Joplin 2.7.2 - Database v41

@laurent22 Please label this so I don't have to keep updating this

github-actions[bot] commented 2 years ago

Hey there, it looks like there has been no activity on this issue recently. Has the issue been fixed, or does it still require the community's attention? If you require support or are requesting an enhancement or feature then please create a topic on the Joplin forum. This issue may be closed if no further activity occurs. You may comment on the issue and I will leave it open. Thank you for your contributions.

Jonta commented 2 years ago

Still requires the community's attention

Joplin 2.7.2 - Database v41

@laurent22 Please label this so I don't have to keep updating this

github-actions[bot] commented 2 years ago

Hey there, it looks like there has been no activity on this issue recently. Has the issue been fixed, or does it still require the community's attention? If you require support or are requesting an enhancement or feature then please create a topic on the Joplin forum. This issue may be closed if no further activity occurs. You may comment on the issue and I will leave it open. Thank you for your contributions.

Jonta commented 2 years ago

Still requires the community's attention

Joplin 2.8.1 - Database v41

@laurent22 Please label this so I don't have to keep updating this

github-actions[bot] commented 2 years ago

Hey there, it looks like there has been no activity on this issue recently. Has the issue been fixed, or does it still require the community's attention? If you require support or are requesting an enhancement or feature then please create a topic on the Joplin forum. This issue may be closed if no further activity occurs. You may comment on the issue and I will leave it open. Thank you for your contributions.

Jonta commented 2 years ago

Still requires the community's attention

Joplin 2.8.1 - Database v41

@laurent22 Please label this so I don't have to keep updating this

github-actions[bot] commented 2 years ago

Hey there, it looks like there has been no activity on this issue recently. Has the issue been fixed, or does it still require the community's attention? If you require support or are requesting an enhancement or feature then please create a topic on the Joplin forum. This issue may be closed if no further activity occurs. You may comment on the issue and I will leave it open. Thank you for your contributions.

Jonta commented 2 years ago

Still requires the community's attention

Joplin 2.8.1 - Database v41

@laurent22 Please label this so I don't have to keep updating this

github-actions[bot] commented 2 years ago

Hey there, it looks like there has been no activity on this issue recently. Has the issue been fixed, or does it still require the community's attention? If you require support or are requesting an enhancement or feature then please create a topic on the Joplin forum. This issue may be closed if no further activity occurs. You may comment on the issue and I will leave it open. Thank you for your contributions.

Jonta commented 2 years ago

Still requires the community's attention

Joplin 2.8.1 - Database v41

@laurent22 Please label this so I don't have to keep updating this

github-actions[bot] commented 2 years ago

Hey there, it looks like there has been no activity on this issue recently. Has the issue been fixed, or does it still require the community's attention? If you require support or are requesting an enhancement or feature then please create a topic on the Joplin forum. This issue may be closed if no further activity occurs. You may comment on the issue and I will leave it open. Thank you for your contributions.

Jonta commented 2 years ago

Still requires the community's attention

Joplin 2.8.1 - Database v41

@laurent22 Please label this so I don't have to keep updating this

github-actions[bot] commented 1 year ago

Hey there, it looks like there has been no activity on this issue recently. Has the issue been fixed, or does it still require the community's attention? If you require support or are requesting an enhancement or feature then please create a topic on the Joplin forum. This issue may be closed if no further activity occurs. You may comment on the issue and I will leave it open. Thank you for your contributions.

Jonta commented 1 year ago

Still requires the community's attention

Joplin 2.8.1 - Database v41

@laurent22 Please label this issue so I don't have to keep updating this

github-actions[bot] commented 1 year ago

Hey there, it looks like there has been no activity on this issue recently. Has the issue been fixed, or does it still require the community's attention? If you require support or are requesting an enhancement or feature then please create a topic on the Joplin forum. This issue may be closed if no further activity occurs. You may comment on the issue and I will leave it open. Thank you for your contributions.

laurent22 commented 1 year ago

I can't replicate this. Please provide a screenshot

Jonta commented 1 year ago

I can't replicate this. Please provide a screenshot

1