laurent22 / joplin

Joplin - the privacy-focused note taking app with sync capabilities for Windows, macOS, Linux, Android and iOS.
https://joplinapp.org
Other
45.09k stars 4.91k forks source link

`**name:**dantezhu` render unexpeced #5022

Closed dantezhu closed 3 years ago

dantezhu commented 3 years ago

Environment

Joplin version: 1.8.5 Platform: Windows and macOS OS specifics: Windows10 and macOS10

Steps to reproduce

  1. type **name:**dantezhu

Describe what you expected to happen

render like this: image

but the right render should be like this: image

but github markdown render unexpected too: name:dantezhu

so I don't know if this is a bug.

Logfile

roman-r-m commented 3 years ago

Does not seem to be a bug - both commonmark & markdownId render the same as Joplin:

https://spec.commonmark.org/dingus/?text=**name%3A**dantezhu https://markdown-it.github.io/#md3=%7B%22source%22%3A%22%2A%2Aname%3A%2A%2Adantezhu%22%2C%22defaults%22%3A%7B%22html%22%3Afalse%2C%22xhtmlOut%22%3Afalse%2C%22breaks%22%3Afalse%2C%22langPrefix%22%3A%22language-%22%2C%22linkify%22%3Afalse%2C%22typographer%22%3Afalse%2C%22_highlight%22%3Afalse%2C%22_strict%22%3Afalse%2C%22_view%22%3A%22html%22%7D%7D

CalebJohn commented 3 years ago

This is not a bug, but it's certainly new to me! Joplin (mostly) follows the commonmark spec, you can find the relevant section here. I will copy the relevant paragraph below. This paragraph gives rules about the closing ** (called a right-flanking delimiter run).

A right-flanking delimiter run is a delimiter run that is (1) not preceded by Unicode whitespace, and either (2a) not preceded by a punctuation character, or (2b) preceded by a punctuation character and followed by Unicode whitespace or a punctuation character. For purposes of this definition, the beginning and the end of the line count as Unicode whitespace.

I've bolded item (2a) because it is the relevant rule.

dantezhu commented 3 years ago

thanks you very much