laurent22 / joplin

Joplin - the privacy-focused note taking app with sync capabilities for Windows, macOS, Linux, Android and iOS.
https://joplinapp.org
Other
46k stars 5k forks source link

Accessibility: missing labels #5603

Open nullatonce opened 3 years ago

nullatonce commented 3 years ago

Environment

Joplin version: 2.4.12 Platform: Windows 10 OS specifics:

Steps to reproduce

1.start screen reader

  1. start joplin
  2. navigate with keyboard

Describe what you expected to happen

Elements to have names so screen readers would work

DESCRIPTION:

To keep it simpler all of my navigation writing this issue was with arrow down. WSR - built in Windows Screen Reader (ctrl+win+enter) I noticed that WSR and NVDA ( Non Visual Desktop Enviroment) on some elements act differently, if no screen reader specified assume that behavior is the same.

1.First element that is pronounced is "Notebooks" moving to next element screen reader reads: "button"

2.Moving to next element after "button": WSR: link; NVDA: clickable; (This is for each list item of Notebooks)

  1. After 2there is a link of "All notes" (works, mentioned as reference).

  2. Element aAfter 3: NVDA:clickable WSR: link

  3. Button after "Search" has no label *so assuming it's to search).

  4. After "New To-Do" and "New Note" checkbox has no label

github-actions[bot] commented 2 years ago

Hey there, it looks like there has been no activity on this issue recently. Has the issue been fixed, or does it still require the community's attention? This issue may be closed if no further activity occurs. You may comment on the issue and I will leave it open. Thank you for your contributions.

mak2002 commented 2 years ago

Hey there @nullatonce , I am new here and want to start contributing. Is this issue good for newbie if yes I would like to work on this

vgjh2005 commented 1 year ago

Hi @mak2002 Still here. Please fix it!

personalizedrefrigerator commented 3 months ago

2024 status update:

1. First element that is pronounced is "Notebooks" moving to next element screen reader reads: "button"

The element just after "Notebooks" is now read as "New, pushbutton" (changed here). (Orca screen reader on Ubuntu 24.04).

2. Moving to next element after "button": WSR: link; NVDA: clickable; (This is for each list item of Notebooks)

Moving to the next element after "New, pushbutton":

For the next item (for me, a notebook called "scheduling" with an alarmclock icon):

Other notebooks are read similarly. Notebooks with no subnotebooks don't have the "Expand notebook name here link".

4. After 2 there is a link of "All notes" (works, mentioned as reference). 5. Element aAfter 3: NVDA:clickable WSR: link Button after "Search" has no label *so assuming it's to search).

The button is now read as "Search pushbutton" when not searching. Focusing it and pressing space focuses the search input. While searching, the button reads "Clear search pushbutton".

After "New To-Do" and "New Note" checkbox has no label

After creating a task with "new to-do", then focusing it in the note list (ctrl-shift-l) the checkbox for the to-do is difficult to focus and still has no label.