Notebook icon does not show in 'Move to Notebook' dropdown menu

laurent22 / joplin

Joplin - the privacy-focused note taking app with sync capabilities for Windows, macOS, Linux, Android and iOS.

https://joplinapp.org

Other

45.1k stars 4.9k forks source link

Notebook icon does not show in 'Move to Notebook' dropdown menu #6292

Open mak2002 opened 2 years ago

mak2002 commented 2 years ago

Notebook icons are not appearing in 'Move to Notebook' dropdown menu(below image). bug-pic

Environment

Joplin version: 2.7.15 (prod) Platform: Linux OS specifics: Ubuntu 20.04 LTS

Steps to reproduce

Make a notebook with some icon
Make a note/todo and right click on it.
On clicking dropdown menu it shows list of notebook without icons.

Describe what you expected to happen

Notebook icons should be displayed in the drop down list.

mak2002 commented 2 years ago

I think adding "desktop" as a label would be helpful as when I tested this on android tablet it is showing the icons. It would be great if anybody can confirm this.

husain3012 commented 2 years ago

I am trying to work on this issue, but I am facing a problem. When the emoji is a user uploaded image, I am getting a base64 string instead of the image, obviously. Currently, I can not think of a way to render an image as an emoji (without the need for an image tag or a react node) One workaround is to use something like 🖼️ for custom images. As for android, currently, nothing is shown for custom images. Kindly push me in the right direction.

entrymaster commented 2 years ago

Is this bug for mobile or desktop?

husain3012 commented 2 years ago

Is this bug for mobile or desktop?

desktop, but for some reason it's labelled as mobile

entrymaster commented 2 years ago

I have observed that on Mobile App there isn't an option for adding a icon to notebook while creating a notebook. Also no icon appears in "Move Notebook" modal. So do this issue aims to add icon feature in mobile too or seperate issue can be created for that ?

mak2002 commented 2 years ago

I had initially created this issue for icon not showing on desktop, but didn't know that we can't add icons for notebook in mobile. Thanks for letting us know.

As far as creating a new issue goes, let's see what @laurent22 has to say.

roman-r-m commented 2 years ago

Can i work on this issue?

yes

entrymaster commented 2 years ago

I have observed that on Mobile App there isn't an option for adding a icon to notebook while creating a notebook. Also no icon appears in "Move Notebook" modal. So do this issue aims to add icon feature in mobile too or seperate issue can be created for that ?

@roman-r-m Can u please confirm this ?

BalanaguYashwanth commented 2 years ago

I had initially created this issue for icon not showing on desktop, but didn't know that we can't add icons for notebook in mobile. Thanks for letting us know.

As far as creating a new issue goes, let's see what @laurent22 has to say.

Is the issue in desktop or mobile currently ? @laurent22 @roman-r-m

roman-r-m commented 2 years ago

Is the issue in desktop or mobile currently ? @laurent22 @roman-r-m

I don't know but it's very easy to check isn't it?

BalanaguYashwanth commented 2 years ago

I don't know but it's very easy to check isn't it? @roman-r-m

To check in mobile version, i can download app from google playstore and check directly ?

roman-r-m commented 2 years ago

Yes. Or you can also build from sources, whatever you prefer

BalanaguYashwanth commented 2 years ago

Yes. Or you can also build from sources, whatever you prefer

Thanks @roman-r-m

BalanaguYashwanth commented 2 years ago

Finally i added this feature for desktop, so can i raise PR ?

Kindly express your thoughts.

roman-r-m commented 2 years ago

Finally i added this feature for desktop, so can i raise PR ?

Of course. Make sure to check the PR guidelines first.

And please stop @-ing people, this does not help at all

BalanaguYashwanth commented 2 years ago

And please stop @-ing people, this does not help at all