search

laurent22 / joplin

Joplin - the secure note taking and to-do app with synchronisation capabilities for Windows, macOS, Linux, Android and iOS.
https://joplinapp.org
Other
44.93k stars 4.88k forks source link

AppImage without icon on application launcher/menu #6596

Open tomoem opened 2 years ago

tomoem commented 2 years ago

Environment

Joplin version: 2.8.8 Platform: Linux OS specifics: Manjaro KDE

Steps to reproduce

  1. Install Joplin AppImage with AppImageLauncher

Describe what you expected to happen

Shortcut to launch the app with icon on application launcher/menu

Workaround

Edit the .desktop file and change the line: Icon=appimagekit_8cb935bf36563d4a453941d2cd6ed778_joplin to: Icon=appimagekit_8cb935bf36563d4a453941d2cd6ed778_@joplinapp-desktop

Note: this doesn't happen with other AppImages on the same OS.

roman-r-m commented 2 years ago

This fixes the icon for me (also Manjaro KDE)

btafoya commented 2 years ago

Same issue with Kubuntu 22.045.

github-actions[bot] commented 2 years ago

Hey there, it looks like there has been no activity on this issue recently. Has the issue been fixed, or does it still require the community's attention? If you require support or are requesting an enhancement or feature then please create a topic on the Joplin forum. This issue may be closed if no further activity occurs. You may comment on the issue and I will leave it open. Thank you for your contributions.

tomoem commented 2 years ago

Hey there, it looks like there has been no activity on this issue recently. Has the issue been fixed, or does it still require the community's attention? If you require support or are requesting an enhancement or feature then please create a topic on the Joplin forum. This issue may be closed if no further activity occurs. You may comment on the issue and I will leave it open. Thank you for your contributions.

Still not fixed.

github-actions[bot] commented 2 years ago

Hey there, it looks like there has been no activity on this issue recently. Has the issue been fixed, or does it still require the community's attention? If you require support or are requesting an enhancement or feature then please create a topic on the Joplin forum. This issue may be closed if no further activity occurs. You may comment on the issue and I will leave it open. Thank you for your contributions.

btafoya commented 2 years ago

Hey there, it looks like there has been no activity on this issue recently. Has the issue been fixed, or does it still require the community's attention? If you require support or are requesting an enhancement or feature then please create a topic on the Joplin forum. This issue may be closed if no further activity occurs. You may comment on the issue and I will leave it open. Thank you for your contributions.

Any movement here? Thanks!

github-actions[bot] commented 1 year ago

Hey there, it looks like there has been no activity on this issue recently. Has the issue been fixed, or does it still require the community's attention? If you require support or are requesting an enhancement or feature then please create a topic on the Joplin forum. This issue may be closed if no further activity occurs. You may comment on the issue and I will leave it open. Thank you for your contributions.

tomoem commented 1 year ago

Issue still exists.

github-actions[bot] commented 1 year ago

Hey there, it looks like there has been no activity on this issue recently. Has the issue been fixed, or does it still require the community's attention? If you require support or are requesting an enhancement or feature then please create a topic on the Joplin forum. This issue may be closed if no further activity occurs. You may comment on the issue and I will leave it open. Thank you for your contributions.

tomoem commented 1 year ago

Tested with v2.9.12 (Pre-release), and issue remains unsolved.

roman-r-m commented 1 year ago

Looks like the issue is due to the package name being @joplin/app-deskop. Electron-builder appears to be using this for the icon name and creates files like /usr/share/icons/hicolor/1024x1024/apps/@joplinapp-desktop.png

I was hoping that simply setting this in package.json would fix that:

    "linux": {
      "desktop": {
        "Icon": "@joplinapp-desktop",
      },

but alas, AppImageLauncher converts the above to

Icon=appimagekit_763f0085fa874c20be9277829b274af6__joplinapp-desktop
roman-r-m commented 1 year ago

Could be an issue with AppImageLauncher or one of its dependencies. Posted more details here: https://github.com/TheAssassin/AppImageLauncher/issues/438#issuecomment-1306370196

2shrestha22 commented 1 year ago

Same issue here with KDE on Arch.

2shrestha22 commented 1 year ago

appimagelint gives flowing output about not finding icon.

./appimagelint-x86_64.AppImage ~/Applications/Joplin-2.8.8_4030a351986a6eaff99fecbe383e65aa.AppImage
appimagelint.cli[23969] [INFO] Checking AppImage /home/sangam/Applications/Joplin-2.8.8_4030a351986a6eaff99fecbe383e65aa.AppImage
appimagelint.cli[23969] [INFO] Running check "GNU libc ABI check"
appimagelint.glibc_abi_check[23969] [INFO] detected required version for runtime: 2.3.3
appimagelint.glibc_abi_check[23969] [INFO] detected required version for payload: 2.17
appimagelint.cache[23969] [INFO] Fetching glibc version data for debian
appimagelint.setup[23969] [INFO] Fetching glibc package versions from Debian sources API
appimagelint.glibc_abi_check[23969] [INFO] [✔] AppImage can run on Debian oldstable (buster)
appimagelint.glibc_abi_check[23969] [INFO] [✔] AppImage can run on Debian stable (bullseye)
appimagelint.glibc_abi_check[23969] [INFO] [✔] AppImage can run on Debian testing (bookworm)
appimagelint.glibc_abi_check[23969] [INFO] [✔] AppImage can run on Debian unstable (sid)
appimagelint.cache[23969] [INFO] Fetching glibc version data for ubuntu
appimagelint.setup[23969] [INFO] Fetching glibc package versions from Ubuntu FTP mirror
appimagelint.glibc_abi_check[23969] [INFO] [✔] AppImage can run on Ubuntu kinetic
appimagelint.glibc_abi_check[23969] [INFO] [✔] AppImage can run on Ubuntu jammy
appimagelint.glibc_abi_check[23969] [INFO] [✔] AppImage can run on Ubuntu focal
appimagelint.glibc_abi_check[23969] [INFO] [✔] AppImage can run on Ubuntu bionic
appimagelint.glibc_abi_check[23969] [INFO] [✔] AppImage can run on Ubuntu xenial
appimagelint.glibc_abi_check[23969] [INFO] [✔] AppImage can run on Ubuntu trusty
appimagelint.cache[23969] [INFO] Fetching glibc version data for centos
appimagelint.setup[23969] [INFO] Fetching glibc package versions from CentOS mirror
appimagelint.glibc_abi_check[23969] [INFO] [✔] AppImage can run on CentOS 7
appimagelint.cli[23969] [INFO] Running check "GNU libstdc++ ABI check"
appimagelint.glibcxx_abi_check[23969] [INFO] detected required version for runtime: <none>
appimagelint.glibcxx_abi_check[23969] [INFO] detected required version for payload: 3.4
appimagelint.cache[23969] [INFO] Fetching glibcxx version data for debian
appimagelint.gnu_lib_versions_symbols_finder[23969] [WARNING] no binaries found in /dev/shm/appimagelint-d_4e2mp3.tmp/out/
appimagelint.gnu_lib_versions_symbols_finder[23969] [WARNING] no binaries found in /dev/shm/appimagelint-6m18runc.tmp/out/
appimagelint.gnu_lib_versions_symbols_finder[23969] [WARNING] no binaries found in /dev/shm/appimagelint-zxhpl8ef.tmp/out/
appimagelint.gnu_lib_versions_symbols_finder[23969] [WARNING] no binaries found in /dev/shm/appimagelint-j9zmev08.tmp/out/
appimagelint.glibcxx_abi_check[23969] [INFO] [✔] AppImage can run on Debian oldstable (buster)
appimagelint.glibcxx_abi_check[23969] [INFO] [✔] AppImage can run on Debian stable (bullseye)
appimagelint.glibcxx_abi_check[23969] [INFO] [✔] AppImage can run on Debian testing (bookworm)
appimagelint.glibcxx_abi_check[23969] [INFO] [✔] AppImage can run on Debian unstable (sid)
appimagelint.cache[23969] [INFO] Fetching glibcxx version data for ubuntu
appimagelint.gnu_lib_versions_symbols_finder[23969] [WARNING] no binaries found in /dev/shm/appimagelint-31eduoro.tmp/out/
appimagelint.gnu_lib_versions_symbols_finder[23969] [WARNING] no binaries found in /dev/shm/appimagelint-89g0mp9w.tmp/out/
appimagelint.gnu_lib_versions_symbols_finder[23969] [WARNING] no binaries found in /dev/shm/appimagelint-3b3cb36i.tmp/out/
appimagelint.gnu_lib_versions_symbols_finder[23969] [WARNING] no binaries found in /dev/shm/appimagelint-eje1ic5n.tmp/out/
appimagelint.gnu_lib_versions_symbols_finder[23969] [WARNING] no binaries found in /dev/shm/appimagelint-98101iir.tmp/out/
appimagelint.gnu_lib_versions_symbols_finder[23969] [WARNING] no binaries found in /dev/shm/appimagelint-z9wup1rp.tmp/out/
appimagelint.glibcxx_abi_check[23969] [INFO] [✔] AppImage can run on Ubuntu kinetic
appimagelint.glibcxx_abi_check[23969] [INFO] [✔] AppImage can run on Ubuntu jammy
appimagelint.glibcxx_abi_check[23969] [INFO] [✔] AppImage can run on Ubuntu focal
appimagelint.glibcxx_abi_check[23969] [INFO] [✔] AppImage can run on Ubuntu bionic
appimagelint.glibcxx_abi_check[23969] [INFO] [✔] AppImage can run on Ubuntu xenial
appimagelint.glibcxx_abi_check[23969] [INFO] [✔] AppImage can run on Ubuntu trusty
appimagelint.cache[23969] [INFO] Fetching glibcxx version data for centos
appimagelint.setup[23969] [INFO] Fetching libstdc++ package versions from CentOS mirror
appimagelint.glibcxx_abi_check[23969] [INFO] [✔] AppImage can run on CentOS 7
appimagelint.cli[23969] [INFO] Running check "Icons validity and location check"
appimagelint.icons_check[23969] [INFO] Extracting icon name from desktop file: /tmp/.mount_JoplinQLEwKN/@joplinapp-desktop.desktop
appimagelint.icons_check[23969] [ERROR] Could not find suitable icon for desktop file's Icon= entry
appimagelint.icons_check[23969] [INFO] [✖] Valid icon in AppDir root
appimagelint.icons_check[23969] [INFO] Checking resolution of icon: /tmp/.mount_JoplinQLEwKN/.DirIcon
appimagelint.icons_check[23969] [WARNING] icon X resolution 1024 is unknown, icon will most likely not be used and just wastes space
appimagelint.icons_check[23969] [WARNING] icon Y resolution 1024 is unknown, icon will most likely not be used and just wastes space
appimagelint.icons_check[23969] [INFO] [✔] Valid icon file in .DirIcon
appimagelint.icons_check[23969] [WARNING] Icon found whose file name doesn't match the Icon= entry in desktop file: hicolor/1024x1024/apps/@joplinapp-desktop.png
appimagelint.icons_check[23969] [WARNING] Icon found whose file name doesn't match the Icon= entry in desktop file: hicolor/128x128/apps/@joplinapp-desktop.png
appimagelint.icons_check[23969] [WARNING] Icon found whose file name doesn't match the Icon= entry in desktop file: hicolor/144x144/apps/@joplinapp-desktop.png
appimagelint.icons_check[23969] [WARNING] Icon found whose file name doesn't match the Icon= entry in desktop file: hicolor/16x16/apps/@joplinapp-desktop.png
appimagelint.icons_check[23969] [WARNING] Icon found whose file name doesn't match the Icon= entry in desktop file: hicolor/24x24/apps/@joplinapp-desktop.png
appimagelint.icons_check[23969] [WARNING] Icon found whose file name doesn't match the Icon= entry in desktop file: hicolor/256x256/apps/@joplinapp-desktop.png
appimagelint.icons_check[23969] [WARNING] Icon found whose file name doesn't match the Icon= entry in desktop file: hicolor/32x32/apps/@joplinapp-desktop.png
appimagelint.icons_check[23969] [WARNING] Icon found whose file name doesn't match the Icon= entry in desktop file: hicolor/48x48/apps/@joplinapp-desktop.png
appimagelint.icons_check[23969] [WARNING] Icon found whose file name doesn't match the Icon= entry in desktop file: hicolor/512x512/apps/@joplinapp-desktop.png
appimagelint.icons_check[23969] [WARNING] Icon found whose file name doesn't match the Icon= entry in desktop file: hicolor/72x72/apps/@joplinapp-desktop.png
appimagelint.icons_check[23969] [WARNING] Icon found whose file name doesn't match the Icon= entry in desktop file: hicolor/96x96/apps/@joplinapp-desktop.png
appimagelint.icons_check[23969] [INFO] [✔] Other integration icons valid
appimagelint.cli[23969] [INFO] Running check "Desktop files existence and validity"
appimagelint.desktop_files[23969] [INFO] Checking desktop files in root directory
appimagelint.desktop_files[23969] [INFO] [✔] Exactly one desktop file in AppDir root
appimagelint.desktop_files[23969] [INFO] Checking desktop file /tmp/.mount_JoplinTEH064/@joplinapp-desktop.desktop with desktop-file-validate
appimagelint.desktop_files[23969] [INFO] [✔] All desktop files in AppDir are valid
k-chapin commented 1 year ago

I don't know if user tomoem experienced the same behavior that I did using Fedora 37 KDE spin after:

  1. Install AppImageLauncher
  2. Install Joplin via Joplin_install_and_update.sh
  3. Launch Joplin
  4. Allow AppImageLauncher to move the Joplin AppImage to its configured path (~/Applications) and perform the remaining installation as it sees fit

Result, two entries in the Application Launcher menu:

  1. Joplin (no icon, created by the Joplin_install_and_update.sh script)
  2. Joplin (2.9.17) (with icon, created by AppImageLauncher)

However, I didn't like the fact that AppImageLauncher moved the Joplin AppImage from the original path employed by the, IMHO excellent, install and update script (Joplin_install_and_update.sh). So, I used the AppImageLauncher method, "Remove AppImage from system", to clean up what AppImageLauncher did, then removed the various directories built by the script

rm -r ~/.joplin
rm -r ~/.config/joplin-desktop
rm -r ~/.config/Joplin
rm ~/.local/share/applications/appimagekit-joplin.desktop

At this point I consider the system to be "Joplin free" so I then used the script to install Joplin again. Result: Joplin entry in the Application Launcher but no icon.

I found the Joplin_install_and_update.sh script correctly placed the "joplin.png" file into ~/.local/share/icons/hicolor/512x512/apps/. Inspecting the ~/.local/share/applications/appimagekit-joplin.desktop file, I made the following changes:

# Icon=@joplinapp-desktop
Icon=joplin.png

After saving the file, the Application Launcher entry correctly displayed the icon for the Joplin entry.

I hope this helps?

tomoem commented 1 year ago

@k-chapin, I didn't use the script, just installed through AppImageLauncher.