search

laurent22 / joplin

Joplin - the privacy-focused note taking app with sync capabilities for Windows, macOS, Linux, Android and iOS.
https://joplinapp.org
Other
45.76k stars 4.97k forks source link

S3 sync didn't support proxy #9138

Open fonlan opened 1 year ago

fonlan commented 1 year ago

Environment

Joplin version: v2.13.3 Platform: Windows OS specifics: Win11 22H2 22621.2283

Steps to reproduce

  1. Add proxy setting in Joplin desktop synchronization advanced seetings.
  2. Enable sync with S3 provider(In my testing I use Aliyun OSS)
  3. Check synchronisation configuration. It will print Error. Please check that URL, username, password, etc. are correct and that the sync target is accessible. The reported error was: connect ETIMEDOUT 47.110.177.36:443 (Code ETIMEDOUT)

Describe what you expected to happen

Sync with S3 via proxy should be successful. I tried same S3 configuration in my Joplin android, it works. I tried WebDav via proxy in Joplin windows desktop application, also works. But only S3 sync with proxy setting failed.

Logfile

image

laurent22 commented 1 year ago

Looks like it can be done by setting the http agent on the S3Client: https://stackoverflow.com/questions/66969381/how-to-configure-nodejs-aws-sdk-using-s3-client-library-with-proxy

If someone is interested in creating a PR we can merge it.

migueltsantana commented 5 months ago

@laurent22 Could you give us an update on this topic? I was using S3 buckets too and when I use the software within my corporate computer, I have this problem. Can you configure the Joplin software to go through the computer's proxy like some applications do? That would be great and we would not need to manually configure it.