search

laurent22 / joplin

Joplin - the secure note taking and to-do app with synchronisation capabilities for Windows, macOS, Linux, Android and iOS.
https://joplinapp.org
Other
44.86k stars 4.87k forks source link

Error in Joplin Install & Update Script #9608

Open Perkolator opened 8 months ago

Perkolator commented 8 months ago

Operating system

Linux

Joplin version

2.13.11

Desktop version info

No response

Current behaviour

In the X-GNOME-SingleWindow=true // should be removed eventually as it was upstream to be an XDG specification line the tailing comment is written to the Desktop Entry file.

The comment should be outside the cat >> ... EOF Bash HereDoc block, and changed to a proper bash comment.

As per the Desktop Entry Specification, the comment written to the Desktop Entry file is not a correct comment and the whole line with the comment is parsed:

Comments Lines beginning with a # and blank lines are considered comments and will be ignored, however they should be preserved across reads and writes of the desktop entry file.

OR, should X-GNOME-SingleWindow=true be removed by now?

I would have fixed the code myself with a PR but I don't know if this line should be removed completely.

Expected behaviour

No response

Logs

No response

github-actions[bot] commented 7 months ago

Hey there, it looks like there has been no activity on this issue recently. Has the issue been fixed, or does it still require the community's attention? If you require support or are requesting an enhancement or feature then please create a topic on the Joplin forum. This issue may be closed if no further activity occurs. You may comment on the issue and I will leave it open. Thank you for your contributions.

Perkolator commented 7 months ago

still not fixed

github-actions[bot] commented 6 months ago

Hey there, it looks like there has been no activity on this issue recently. Has the issue been fixed, or does it still require the community's attention? If you require support or are requesting an enhancement or feature then please create a topic on the Joplin forum. This issue may be closed if no further activity occurs. You may comment on the issue and I will leave it open. Thank you for your contributions.

Perkolator commented 6 months ago

still not fixed

github-actions[bot] commented 5 months ago

Hey there, it looks like there has been no activity on this issue recently. Has the issue been fixed, or does it still require the community's attention? If you require support or are requesting an enhancement or feature then please create a topic on the Joplin forum. This issue may be closed if no further activity occurs. You may comment on the issue and I will leave it open. Thank you for your contributions.

Perkolator commented 5 months ago

still not fixed

github-actions[bot] commented 3 months ago

Hey there, it looks like there has been no activity on this issue recently. Has the issue been fixed, or does it still require the community's attention? If you require support or are requesting an enhancement or feature then please create a topic on the Joplin forum. This issue may be closed if no further activity occurs. You may comment on the issue and I will leave it open. Thank you for your contributions.

Perkolator commented 3 months ago

still not fixed

github-actions[bot] commented 2 months ago

Hey there, it looks like there has been no activity on this issue recently. Has the issue been fixed, or does it still require the community's attention? If you require support or are requesting an enhancement or feature then please create a topic on the Joplin forum. This issue may be closed if no further activity occurs. You may comment on the issue and I will leave it open. Thank you for your contributions.

Perkolator commented 2 months ago

not fixed

github-actions[bot] commented 1 month ago

Hey there, it looks like there has been no activity on this issue recently. Has the issue been fixed, or does it still require the community's attention? If you require support or are requesting an enhancement or feature then please create a topic on the Joplin forum. This issue may be closed if no further activity occurs. You may comment on the issue and I will leave it open. Thank you for your contributions.

Perkolator commented 1 month ago

not fixed

github-actions[bot] commented 3 weeks ago

Hey there, it looks like there has been no activity on this issue recently. Has the issue been fixed, or does it still require the community's attention? If you require support or are requesting an enhancement or feature then please create a topic on the Joplin forum. This issue may be closed if no further activity occurs. You may comment on the issue and I will leave it open. Thank you for your contributions.

Perkolator commented 3 weeks ago

not fixed