laurent22 / joplin

Joplin - the secure note taking and to-do app with synchronisation capabilities for Windows, macOS, Linux, Android and iOS.
https://joplinapp.org
Other
44.73k stars 4.85k forks source link

[Bug] If you copy a code block from outside a table and paste it inside of a table, you can no longer double click to edit the code block. #9757

Open futuremotiondev opened 7 months ago

futuremotiondev commented 7 months ago

Operating system

Windows

Joplin version

Joplin 2.14.10 (prod, win32)

Desktop version info

Joplin 2.14.10 (prod, win32)

Client ID: 4dab185d885945ac897a0608af59c6f7 Sync Version: 3 Profile Version: 45 Keychain Supported: Yes

Revision: 3ed6ad5

CodeMirror Options: 1.1.0 Csv Import: 1.0.1 Ez Table: 1.0.2 Favorites: 1.3.2 Menu items, Shortcuts, Toolbar icons: 1.1.0 Quick HTML tags: 0.2.0 Simple Backup: 1.3.6 Simple Highlighter: 1.0.0 Suitcase: 0.3.2 Table Formatter Plugin: 1.2.1 turnToChart: 1.9.3

Current behaviour

  1. Create a document with an empty table, and a code block somewhere else outside of this table.
  2. Click on the code block and then cut it (Ctrl+X), then paste it into a cell of the empty table.
  3. Notice that you can no longer edit the code block by double clicking.

Screen recording:

https://github.com/laurent22/joplin/assets/33441569/6fd62ccf-9b09-4d7c-9bad-e2fbdacb218d

Expected behaviour

I expect Joplin to maintain the editability of the pasted code block. Double clicking the pasted code block should allow me to change it.

Logs

No response

Praveen03AJJARAPU commented 5 months ago

This issue was no longer there when I tried to do that, there was a modal opened showing the language and edit section where we can modify it. This issue can be clo Screenshot 2024-03-05 233221 Screenshot 2024-03-05 233227 sed.

roman-r-m commented 5 months ago

Can confirm, the issue appears to be fixed on the latest commit on dev (5e4c35a18)