Android: Opening the markdown toolbar overflow menu is slow on some devices

laurent22 / joplin

Joplin - the privacy-focused note taking app with sync capabilities for Windows, macOS, Linux, Android and iOS.

https://joplinapp.org

Other

45.32k stars 4.93k forks source link

Open personalizedrefrigerator opened 8 months ago

personalizedrefrigerator commented 8 months ago

Android

2.14.11

No response

Create a new note
Open the markdown toolbar overflow menu (click on the three dots in the middle of the toolbar)

Currently, on my Android device (Android 7), it takes about a second for the toolbar to open. On my iOS device (iOS 17), it's much faster.

Notes:

The Android device tested with above is slower and has less memory than the iOS device.
Currently, React rerenders all of the toolbar buttons when closing/opening the toolbar.

Opening the overflow menu should be fast.

No response

laurent22 commented 8 months ago

On 2.14.5 it works for me. On Samsung S22

RamGoel commented 7 months ago

Hi, What's the markdown toolbar you guys are referring to, the options menu or the styling toolbar. If anything else can you please share a snapshot?

Siddheshuncodes commented 1 week ago

I think they are referring to this delay i have attached a screen recording of my emulator i am using Pixel 7 pro

Siddheshuncodes commented 6 days ago

is this correct or am i missing something i am very new to this so can anyone please guide me how can i contribute to a issue

personalizedrefrigerator commented 6 days ago

is this correct or am i missing something i am very new to this so can anyone please guide me how can i contribute to a issue

In general, we don't assign issues. See the contributing guide for general contribution information.

For this issue:

The Markdown toolbar logic can be found here: https://github.com/laurent22/joplin/tree/dev/packages/app-mobile/components/NoteEditor/MarkdownToolbar.
Wrapping ToolbarOverflowRows (or even ToolbarButton) in React.memo might help improve performance by reducing rerenders.