Fix MacOS date parse when GNU date is present. - Githubissues

laurent22 / rsync-time-backup

Time Machine style backup with rsync.

3.38k stars 446 forks source link

Fix MacOS date parse when GNU date is present. #171

Closed jlucktay closed 2 years ago

jlucktay commented 4 years ago

If a MacOS user has installed GNU coreutils via Homebrew and updated $PATH with the new 'gnubin' directory, then the flags supported by 'date' will differ and rsync_tmbackup.sh will throw the following:

[WARNING] Could not parse date

Why is the change necessary? (Bug fix, feature, improvements?)

if GNU date has also been installed, and is overriding/preceding the existing /bin/date binary in $PATH, GNU date will not know what the '-j' flag does, and throws an error causing issues in fn_parse_date()

How does the change address the issue?

by specifying the absolute path to the MacOS date binary, we can make sure that the date binary we call supports the supplied flags

jlucktay commented 2 years ago

Fixed by 7e3618c5140f24ce3c3842b5e3efcf7012e536e0.