First attempt at CI Testing #204

reactive-firewall commented 4 years ago

First attempt at laurent22/rsync-time-backup#204

[x] tests run every time code is pushed to github (auto-tests)
[x] tests show passing example (just a test that usage is output when the -h flag is passed)
[x] tests shows failure case with error
[x] tests check themselves (both passing and failing example)
[x] tests are run in the cloud and thus can be configured to run in multiple environments independent of developer's system (caveat: tests on linux only in this PR)
[x] this PR does not break nor alter non-testing code or function
[x] maintainer can choose to make tests required for merges

🤔 ... Thoughts? Reviews? Thumbs up?

fthiery commented 4 years ago

This is extremely needed IMO. Not a reason not to try, but some stuff is impossible to simulate unfortunately (e.g. https://github.com/laurent22/rsync-time-backup/issues/64)

Thanks for working on that

reactive-firewall commented 2 years ago

@fthiery

but some stuff is impossible to simulate unfortunately (e.g. #64)

TL;DR I think you're missing an important "easily" between "to" and "simulate. With that assumption it might be worth pointing out that this (#64) kind of use-case would best be tested by mocking the issue. By mocking the failed output of rsync we can skip the long time of waiting on rsync while testing this case. This test would be something like replacing the rsync command with a mocked rsync script that just outputs the lost error behavior without the data, thus separating out the fail case so it may be used to test the handling function.

caveat: however I could be totally wrong and you may mean something else.

laurent22 / rsync-time-backup

First attempt at CI Testing #204 #205