fix: limit_value typehint for limit function

laurentS / slowapi

A rate limiter for Starlette and FastAPI

https://pypi.org/project/slowapi/

MIT License

1.24k stars 79 forks source link

fix: limit_value typehint for limit function #166

Closed PookieBuns closed 1 year ago

PookieBuns commented 1 year ago

The limit_decorator function takes a strOrCallableStr for its limit_value parameter. Update Limiter.limit function's lmit_value typehint to follow the same type hints as to pass to the limit_decorator_function

PookieBuns commented 1 year ago

Hi guys I'm new to open-sourcing so please let me know if I'm missing anything or if I'm not following correct protocol

laurentS commented 1 year ago

Hi @PookieBuns thanks for opening this PR. I think you're following protocol :) Welcome to the cool world of open-source!

laurentS commented 1 year ago

Force merging this, as the only problem is the commit description (and I'm not even sure why Semantic PR complains about it)