search

laurentj / slimerjs

A scriptable browser like PhantomJS, based on Firefox
http://slimerjs.org
Other
3k stars 259 forks source link

slimerjs.bat does not handle --version #145

Open paazmaya opened 10 years ago

paazmaya commented 10 years ago

Even though stated in the help output, there is no handler for printing out version information.

laurentj commented 10 years ago

It handles this parameter. In fact, it is handled by XulRunner, like some other parameters. But it seems that XulRunner has a bug with this parameter, on the windows version...

paazmaya commented 10 years ago

Is this parameter supposed to give the version of XulRunner/Firefox instead of SlimerJS ? Should it be documented?

laurentj commented 10 years ago

No, this parameter displays the application version, informations stored into the application.ini.

No documentation change is needed, no fix can be done into SlimerJS. This is only an issue of XulRunner / Firefox with --version.

paazmaya commented 10 years ago

Perhaps it could be documented that it returns the version of the third party applications, thus not directly a part pf SlimerJS... or somehow similarly

laurentj commented 10 years ago

Probably you misunderstood what I wrote.

The parameter --version displays the version of SlimerJS (which is written into the application.ini file). This parameter is not handle by SlimerJS but by the framework on which it is based : XulRunner. If Firefox is used, this is the same thing : Firefox is an application based on XulRunner, and SlimerJS uses only the XulRunner part of Firefox when Firefox is used to launch SlimerJS.

So, for me, the documentation is ok. Or I don't understand what you would like.

paazmaya commented 10 years ago

Thank you for the clarification, seems I had misunderstood the earlier comment.

laurentj commented 10 years ago

Reopened it until it is not fixed in XulRunner

paazmaya commented 9 years ago

Is there a place where XulRunner issues exists?

paazmaya commented 9 years ago

Found it, https://bugzilla.mozilla.org/buglist.cgi?query_format=advanced&short_desc_type=allwordssubstr&short_desc=&product=Toolkit&component=XULRunner&long_desc_type=substring&long_desc=&bug_file_loc_type=allwordssubstr&bug_file_loc=&status_whiteboard_type=allwordssubstr&status_whiteboard=&keywords_type=allwords&keywords=&bug_status=UNCONFIRMED&bug_status=NEW&bug_status=ASSIGNED&bug_status=REOPENED&resolution=---&emailassigned_to1=1&emailtype1=exact&email1=&emailassigned_to2=1&emailreporter2=1&emailqa_contact2=1&emailtype2=exact&email2=&bugidtype=include&bug_id=&votes=&chfieldfrom=&chfieldto=Now&chfieldvalue=&cmdtype=doit&order=Reuse+same+sort+as+last+time&field0-0-0=noop&type0-0-0=noop&value0-0-0=