search

laurentj / slimerjs

A scriptable browser like PhantomJS, based on Firefox
http://slimerjs.org
Other
3k stars 259 forks source link

Binding issue with casper #491

Open Huulivoide opened 8 years ago

Huulivoide commented 8 years ago

Trying to run anything with current casper master and slimer 0.10/master will result in the following error: [Exception] TypeError: this.filter is not a function filename:file:///foo/casperjs/modules/casper.js line:677

I am not sure if this is a bug in Casper or Slimer. Casper bug: https://github.com/casperjs/casperjs/issues/1607

How to reproduce on Linux (tested on Arch Linux):

git clone https://github.com/casperjs/casperjs.git git clone https://github.com/laurentj/slimerjs.git curl https://download-installer.cdn.mozilla.net/pub/firefox/releases/46.0.1/linux-x86_64/en-US/firefox-46.0.1.tar.bz2 | tar xj export SLIMERJSLAUNCHER="$(pwd)/firefox/firefox" export PATH="$(pwd)/slimerjs/src/:$PATH" ./casperjs/bin/casperjs --engine=slimerjs selftest

paazmaya commented 8 years ago

Same issue in Mac, CasperJS 1.1.1, SlimerJS 0.10.0

mlalpho commented 8 years ago

I'm not hitting this during selftest xvfb-run casperjs --engine=slimerjs selftest --log-level=debug --verbose=true

 casperjs --version
1.1.1
 slimerjs --version
Innophi SlimerJS 0.10.0, Copyright 2012-2016 Laurent Jouanneau & Innophi

Running on Oracle Linux 6. Haven't tested any other platforms, yet.

mlalpho commented 8 years ago

I wasn't using slimerjs master (installed from release zip), although I was using casperjs master.

I just did: 

cd /root/
git clone git clone https://github.com/laurentj/slimerjs.git
ln -sf /root/slimerjs/src/slimerjs /usr/bin/slimerjs

and the selftest still passes (with the exception of a logging.js failure)

Curious, though, the slimerjs version isn't at 0.10.0:

slimerjs --version
Innophi SlimerJS 1.0.0-pre, Copyright 2012-2016 Laurent Jouanneau & Innophi
mlalpho commented 8 years ago

I just tested re-installing casperjs from master using git. I used https://github.com/casperjs/casperjs/tarball/master previously:

cd /root/
git clone git clone https://github.com/casperjs/casperjs.git
ln -sf /root/casperjs/bin/casperjs /usr/bin/casperjs

Could it be that I already have phantomjs installed and this isn't a "clean" system so-to-speak? Casper using phantom at some point until it finds out the --engine is overridden?

wesvetter commented 7 years ago

Could this be related? https://github.com/laurentj/slimerjs/issues/604