laurentkneip / opengv

OpenGV is a collection of computer vision methods for solving geometric vision problems. It is hosted and maintained by the Mobile Perception Lab of ShanghaiTech.
Other
1.02k stars 353 forks source link

Quaternion of unit matrix gives wrong result #99

Open Tobimaru opened 5 years ago

Tobimaru commented 5 years ago

The opengv::math::rot2quaternion function returns a quaternion with NaN values for an identity matrix, while this should be (1, 0, 0, 0). The function opengv::math::quaternion2rot returns an identity matrix for the quaternion (1, 0, 0, 0). Is this intended behavior or can this be considered as a bug?