laurentpertois / Sonoma-Compatibility-Checker

MIT License
5 stars 1 forks source link

False output for compatible computer with macOS 12,13, & 14. #1

Open jbutleru47 opened 1 year ago

jbutleru47 commented 1 year ago

For a MacBook Pro 2019, Sonoma, Ventura, and Monterey checkers all come up as false. Not sure what is breaking down here, thought I'd mention it.

dmote75 commented 9 months ago

Just now using this and it's definitely off. Finally allowing my users to Upgrade and this is not accurate.

laurentpertois commented 9 months ago

Can any of you send me the output for these commands on devices where you think it's not accurate?

sw_vers -buildVersion /usr/sbin/sysctl -n hw.model /usr/sbin/sysctl -n hw.memsize diskutil info / | awk -F '[()]' '/Free Space|Available Space/ {print $2}' | sed -e 's/\ Bytes//'

Thanks a lot!

dmote75 commented 9 months ago

I can tell you my MacBook Air is already on 14.2 yet the extension Attribute reports "False". Here is the output from running on that machine: 23C64 MacBookAir10,1 8589934592 58683547648

laurentpertois commented 9 months ago

Hi @dmote75

Thanks for coming back, actually you answered the next question. By default, we set the answer to false if you run Sonoma already. You can change that line 109 as stated in the comments:

# Checks if computer meets pre-requisites for Sonoma # This also means that if the computer is already running Sonoma it will be marked as false # You can change this behaviour by modifying the 22 into a 23 if [[ "$OSVERSIONMAJOR" -ge 13 && "$OSVERSIONMAJOR" -le 22 ]]; then

The main idea is that the extension attribute works to identify computers that are ready to install Sonoma, and if it's already running Sonoma, we don't need to install again.

Kind regards,

dmote75 commented 9 months ago

Ahhhh Okay, sorry about missing that. Let me change that and see how it reports. Thanks!

laurentpertois commented 9 months ago

No worries @dmote75 you're not the first... I guess at some point I should revert it to something that might make more sense to most users...