laurenz / oracle_fdw

PostgreSQL Foreign Data Wrapper for Oracle
http://laurenz.github.io/oracle_fdw/
Other
496 stars 156 forks source link

Add `IMPORT FOREIGN SCHEMA` options #658

Closed mkgrgis closed 8 months ago

mkgrgis commented 8 months ago

This is a draft for https://github.com/laurenz/oracle_fdw/issues/656. @laurenz , feel free to use and modify it. In this PR

laurenz commented 8 months ago

Thanks! I finished the implementation, polished the code and added regression tests.

mkgrgis commented 8 months ago

Thanks, @laurenz ! This was very interesting for me to see how my draft was modified and which code was merged.

laurenz commented 8 months ago

I a particularly grateful for the boolVal(). I could use it so make several parts of the code more readable. I had second thoughts and changed the import_* to skip_*, since I had the impression that would be more intuitive to use.

mkgrgis commented 8 months ago

Thanks to you, @laurenz for skip option conception. I'll discuss with author of firebird_fdw about implementation of similar options, now there is no special options about materialized views an tables. So, oracle_fdw will be a prototype for other implementations as usual ;-)