Closed mkgrgis closed 8 months ago
Thanks! I finished the implementation, polished the code and added regression tests.
Thanks, @laurenz ! This was very interesting for me to see how my draft was modified and which code was merged.
I a particularly grateful for the boolVal()
. I could use it so make several parts of the code more readable.
I had second thoughts and changed the import_*
to skip_*
, since I had the impression that would be more intuitive to use.
Thanks to you, @laurenz for skip
option conception. I'll discuss with author of firebird_fdw
about implementation of similar options, now there is no special options about materialized views an tables. So, oracle_fdw will be a prototype for other implementations as usual ;-)
This is a draft for https://github.com/laurenz/oracle_fdw/issues/656. @laurenz , feel free to use and modify it. In this PR
import_tables
,import_views
,import_materialized_views
options inREADME
file,import_tables
,import_views
,import_materialized_views
options,import_tables
,import_views
,import_materialized_views
inoracleGetImportColumn
signature,oracleGetImportColumn
to more ISO:SQL style and addobject_type
. Final query version isYou can add
AND object_type IN ('...', '...')
inWHERE
based on new flags and your preferred code style. Sorry for my not complete PR, I am just C beginner from sqlite_fdw.